Allowing selected (custom/standard) fields to be updated#158
Open
MytkoEnko wants to merge 10 commits intoprometheus-community:masterfrom
Open
Allowing selected (custom/standard) fields to be updated#158MytkoEnko wants to merge 10 commits intoprometheus-community:masterfrom
MytkoEnko wants to merge 10 commits intoprometheus-community:masterfrom
Conversation
MytkoEnko
force-pushed
the
fields_updates_improvement
branch
2 times, most recently
from
7e8a2f6 to
54ff2a7
Compare
MytkoEnko
changed the title
bwplotka
reviewed
Feb 5, 2024
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Nice, I don't have full context on the use case, but feels like a useful logic. Added some suggestions. Thanks, sorry for lag.
Signed-off-by: MytkoEnko <deass@ukr.net>
Signed-off-by: MytkoEnko <deass@ukr.net>
Signed-off-by: MytkoEnko <deass@ukr.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
MytkoEnko
force-pushed
the
fields_updates_improvement
branch
from
490b55f to
5448540
Compare
Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
MytkoEnko
force-pushed
the
fields_updates_improvement
branch
from
5448540 to
eab7648
Compare
Author
|
@bwplotka Thanks for he review! Applied suggestions and rebased. In our organisation we've mapped alert's $value to an annotation and wanted corresponding jira field to be always up to date as it was important for prioritizing similar alert tickets. |
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
Signed-off-by: Dmytro Aleksieiev <deass@ukr.net>
Author
|
Ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could anyone please review this pr?
It is backward compatible, as by default it does nothing, only in a way that feature might interfere with the logic of (#150) as it might still update some values even if
updateSummaryandupdateDescriptionflags are disabled.If that is ok, I could move these
updateSummary,updateDescriptionandreopenTicketsflags to the config to make it more flexible and allow "per-receiver" configs rather than global flags.Resolves #157