185: Fix unsupported value type msg in log#192
Open
banuchka wants to merge 1 commit intoprometheus-community:masterfrom
Open
185: Fix unsupported value type msg in log#192banuchka wants to merge 1 commit intoprometheus-community:masterfrom
banuchka wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Member
|
Thanks! Amazing -- do you mind rebasing and fixing DCO (signing commit)? |
bwplotka
reviewed
May 23, 2025
| issue := issues[0] | ||
| if len(issues) > 1 { | ||
| level.Warn(r.logger).Log("msg", "more than one issue matched, picking most recently resolved", "query", query, "issues", issues, "picked", issue) | ||
| keys := make([]string, len(issues)) |
Member
There was a problem hiding this comment.
Do you mind adding a quick small function for this?
Signed-off-by: banuchka <tyrchenok@gmail.com>
banuchka
force-pushed
the
GH_jiralert_issue_185
branch
from
db71d89 to
2ccd9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a useful thing to have correct information in log messages.
This PR is to fix an Issue 185