Skip to content

Make nvme_metrics.py work with missing paths #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deajan wants to merge 1 commit into from
Closed

Make nvme_metrics.py work with missing paths #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion nvme_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,15 @@ def exec_nvme(*args):
in child process environment so that the nvme tool does not perform any locale-specific number
or date formatting, etc.
"""
cmd = ["nvme", *args]
nvme_command = None
for sys_path in ['/usr/sbin', '/usr/bin', '/usr/local/sbin', '/usr/local/bin']:
nvme_command = os.path.join(sys_path, 'nvme')
if os.path.isfile(nvme_command):
break
nvme_command = None
if not nvme_command:
raise FileNotFoundError("Did not find command path for {}".format(nvme_command))
cmd = [nvme_command, *args]
return subprocess.check_output(cmd, stderr=subprocess.PIPE, env=dict(os.environ, LC_ALL="C"))


Expand Down