Add --compat-disk-labels option#247
Closed
deajan wants to merge 2 commits intoprometheus-community:masterfrom
Closed
Add --compat-disk-labels option#247deajan wants to merge 2 commits intoprometheus-community:masterfrom
deajan wants to merge 2 commits intoprometheus-community:masterfrom
Conversation
Signed-off-by: Orsiris de Jong <ozy@netpower.fr>
Member
|
If you really need this backwards compatible label, you can achieve it with a Prometheus relabel rule. |
Contributor
Author
|
The problem being that both metrics have a disk entry, and only the ones from smartmon.py would need relabeling. |
Contributor
Author
|
Closed in favor of #256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I use
smartmon.shfor years now.Migrating to
smartmon.py, I really got frustrated because metrics like:became
So basically I have to batch update all my instances, or develop new dashboards (I can't get disk or device variable in grafana, one has to choose).
So my proposition is to add
--compat-disk-labelstosmartmon.pyin order for the latter to generate metrics with the same disk name as previously found insmarmon.sh.Modification is applied explicitly, so no behavior changes for existing setups.