Small fixes for devices which don't support SMART#254
Open
higels wants to merge 1 commit intoprometheus-community:masterfrom
Open
Small fixes for devices which don't support SMART#254higels wants to merge 1 commit intoprometheus-community:masterfrom
higels wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
* initialise smart_healthy to -1, since an int defaults to 0 if empty, which broke some logic further down; as a result we no longer emit healthy=0 for devices with no SMART support. * add a return to parse_smartctl_info to indicate if the device supports smart. if it doesn't, don't bother pulling stats for it Signed-off-by: Steffen Higel <higels@valvesoftware.com>
higels
force-pushed
the
higels-small-non-smart-dev-fixes
branch
from
ad11cd2 to
148ebad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_smartctl_infoto indicate if the device supports smart. if it doesn't, don't bother pulling stats for it