Add nvme-cli 2.3 compat v2#255
Open
deajan wants to merge 2 commits intoprometheus-community:masterfrom
Open
Conversation
Signed-off-by: Orsiris de Jong <ozy@netpower.fr>
Closed
Contributor
Author
|
Script has since been tested on Debian 13 and RHEL 10 too. |
Contributor
Author
|
Any update on this ? Do I need to make any changes to the PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian 12 (proxmox) ships with nvme-cli 2.3 which has no --verbose parameter for smart-log command.
We check if --verbose exists, and deactivate it if not present.
Also added a change that allows a non error exit when no existing nvme devices are found.
Patch has been tested on Debian 12 and RHEL 9 (with nvme-cli 2.11) in order to ensure there is no regression.