Skip to content

chore: Add instance label to the prometheusrule description #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Add instance label to the prometheusrule description #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ef13d
chore: Add instance label to the prometheusrule description
daviderli614 Dec 23, 2024
c310471
chore: add gitignore
daviderli614 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,12 @@ crdschemas/

developer-workspace/gitpod/_output
developer-workspace/codespaces/kind

# editor and IDE paraphernalia
.idea
*.swp
*.swo
*~

# macOS
.DS_Store
2 changes: 1 addition & 1 deletion jsonnet/kube-prometheus/components/mixin/alerts/node.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
alert: 'NodeNetworkInterfaceFlapping',
annotations: {
summary: 'Network interface is often changing its status',
description: 'Network interface "{{ $labels.device }}" changing its up status often on node-exporter {{ $labels.namespace }}/{{ $labels.pod }}',
description: 'The network interface "{{ $labels.device }}" at "{{ $labels.instance }}" changing its up status often on node-exporter {{ $labels.namespace }}/{{ $labels.pod }}',
},
expr: |||
changes(node_network_up{%(nodeExporterSelector)s,%(hostNetworkInterfaceSelector)s}[2m]) > 2
Expand Down
2 changes: 1 addition & 1 deletion manifests/kubePrometheus-prometheusRule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
rules:
- alert: NodeNetworkInterfaceFlapping
annotations:
description: Network interface "{{ $labels.device }}" changing its up status often on node-exporter {{ $labels.namespace }}/{{ $labels.pod }}
description: The network interface "{{ $labels.device }}" at "{{ $labels.instance }}" changing its up status often on node-exporter {{ $labels.namespace }}/{{ $labels.pod }}
runbook_url: https://runbooks.prometheus-operator.dev/runbooks/general/nodenetworkinterfaceflapping
summary: Network interface is often changing its status
expr: |
Expand Down