Skip to content

Conversation

leonnicolas
Copy link

@leonnicolas leonnicolas commented Jan 2, 2025

Update jsonnet packages. The resulting changes come from the update of
https://github.com/kubernetes-monitoring/kubernetes-mixin. Most
importantly it contains an update to fix prometheus recoding rules that
were broken for prometheus v3.

This would close #2575 and #2573

Update jsonnet packages. The resulting changes come from the update of
https://github.com/kubernetes-monitoring/kubernetes-mixin. Most
importantly it contains an update to fix prometheus recoding rules that
were broken for prometheus v3.

This would close prometheus-operator#2575
@leonnicolas leonnicolas requested a review from a team as a code owner January 2, 2025 10:43
@slashpai
Copy link
Contributor

slashpai commented Jan 7, 2025

Thanks for the PR

Can you rebase your branch it shows conflicts? I can approve the workflows to test after that

@philipgough
Copy link
Contributor

@slashpai @leonnicolas - I believe this may be superseded by the automated job that merged yesterday #2581

@leonnicolas
Copy link
Author

leonnicolas commented Jan 7, 2025

@philipgough not quite the changes I care about are from kubernetes-mixin especially this PR. I will update this PR.!

You are right, I missed that one file

@leonnicolas
Copy link
Author

closing in favor or #2581

@leonnicolas leonnicolas closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants