Prometheus server: Update the status of configuration resources at the end of workload reconciliation#8423
Open
haanhvu wants to merge 1 commit intoprometheus-operator:mainfrom
Open
Prometheus server: Update the status of configuration resources at the end of workload reconciliation#8423haanhvu wants to merge 1 commit intoprometheus-operator:mainfrom
haanhvu wants to merge 1 commit intoprometheus-operator:mainfrom
Conversation
…e end of workload reconciliation Signed-off-by: haanhvu <haanhvu888@gmail.com>
Contributor
Author
|
@simonpasquier do I understand the issue correctly or there's more than this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #8382
The issue asks to update the status of configuration resources at the end of workload reconciliation in all controllers. I don't see anywhere else outside of ThanosRuler and Prometheus server where we update the status of configuration resources. The ThanosRuler part was already fixed in #8358. This PR finishes the Prometheus server part.
If there's any other controllers where we need to do this but I missed, please let me know & I'll update the PR.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Prometheus server: Update the status of configuration resources at the end of workload reconciliation