-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add support for updating existing Slack messages #4682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kruchkov-alexandr
wants to merge
2
commits into
prometheus:main
Choose a base branch
from
kruchkov-alexandr:feature/slack-update-existing-messages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+263
β45
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Alertmanager configuration with Slack message updates | ||
| global: | ||
| resolve_timeout: 5m | ||
|
|
||
| # Route configuration - required! | ||
| route: | ||
| receiver: 'slack' | ||
| group_by: ['alertname', 'cluster', 'service'] | ||
| group_wait: 10s | ||
| group_interval: 10s | ||
| repeat_interval: 12h | ||
|
|
||
| receivers: | ||
| - name: 'slack' | ||
| slack_configs: | ||
| - send_resolved: true # Required for message updates! | ||
| api_url: 'https://slack.com/api/chat.postMessage' | ||
| http_config: | ||
| authorization: | ||
| credentials: 'xoxb-your-bot-token' | ||
| channel: '#your-channel' | ||
| update_message: true # This enables message updates! | ||
|
|
||
| # Template for updated messages | ||
| title: '{{ .GroupLabels.alertname }} - {{ .Status | toUpper }}' | ||
| text: | | ||
| {{ if eq .Status "firing" }} | ||
| π₯ *{{ .Alerts.Firing | len }} alert(s) firing* | ||
| {{ else }} | ||
| β *All alerts resolved* | ||
| {{ end }} | ||
|
|
||
| {{ range .Alerts }} | ||
| β’ {{ if .Annotations.summary }}{{ .Annotations.summary }}{{ else }}{{ .Labels.alertname }}{{ end }} | ||
| {{ end }} | ||
|
|
||
| color: '{{ if eq .Status "firing" }}danger{{ else }}good{{ end }}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Copyright 2024 Prometheus Team | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package notify | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "sync" | ||
|
|
||
| "github.com/prometheus/alertmanager/nflog/nflogpb" | ||
| ) | ||
|
|
||
| // MetadataStore is a temporary in-memory store for notification metadata | ||
| // (e.g., Slack message_ts, Jira issue keys) until protobuf Entry supports metadata field. | ||
| // This allows integrations to update existing notifications instead of creating new ones. | ||
| type MetadataStore struct { | ||
| mtx sync.RWMutex | ||
| data map[string]map[string]string // key: stateKey(groupKey, receiver) -> metadata map | ||
| } | ||
|
|
||
| // NewMetadataStore creates a new MetadataStore. | ||
| func NewMetadataStore() *MetadataStore { | ||
| return &MetadataStore{ | ||
| data: make(map[string]map[string]string), | ||
| } | ||
| } | ||
|
|
||
| // Set stores metadata for a given receiver and group key. | ||
| func (s *MetadataStore) Set(receiver *nflogpb.Receiver, groupKey string, metadata map[string]string) { | ||
| s.mtx.Lock() | ||
| defer s.mtx.Unlock() | ||
|
|
||
| key := stateKey(groupKey, receiver) | ||
| s.data[key] = metadata | ||
| } | ||
|
|
||
| // Get retrieves metadata for a given receiver and group key. | ||
| func (s *MetadataStore) Get(receiver *nflogpb.Receiver, groupKey string) (map[string]string, bool) { | ||
| s.mtx.RLock() | ||
| defer s.mtx.RUnlock() | ||
|
|
||
| key := stateKey(groupKey, receiver) | ||
| metadata, ok := s.data[key] | ||
| return metadata, ok | ||
| } | ||
|
|
||
| // Delete removes metadata for a given receiver and group key. | ||
| func (s *MetadataStore) Delete(receiver *nflogpb.Receiver, groupKey string) { | ||
| s.mtx.Lock() | ||
| defer s.mtx.Unlock() | ||
|
|
||
| key := stateKey(groupKey, receiver) | ||
| delete(s.data, key) | ||
| } | ||
|
|
||
| // stateKey returns a string key for a log entry consisting of the group key and receiver. | ||
| // This matches the key generation in nflog. | ||
| func stateKey(gkey string, r *nflogpb.Receiver) string { | ||
| return receiverKey(gkey, r) | ||
| } | ||
|
|
||
| // receiverKey creates a unique key from group key and receiver. | ||
| // Format matches nflog's internal stateKey format: "groupKey:groupName/integration/idx" | ||
| func receiverKey(groupKey string, r *nflogpb.Receiver) string { | ||
| return groupKey + ":" + receiverString(r) | ||
| } | ||
|
|
||
| // receiverString returns a string representation of the receiver. | ||
| func receiverString(r *nflogpb.Receiver) string { | ||
| return fmt.Sprintf("%s/%s/%d", r.GroupName, r.Integration, r.Idx) | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.