Skip to content

template: preserve quoted numeric strings in DeepCopyWithTemplate #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siavashs merged 6 commits into from
Sep 9, 2026
Merged

template: preserve quoted numeric strings in DeepCopyWithTemplate #5098

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a36ca5
feat(deepcopywithtemplate): improvments to keep quoted scalar as string
holger-waschke Mar 18, 2026
0da5231
chore(template_test.go): add additional unit test to test deepcopywit…
holger-waschke Mar 20, 2026
c9b1d81
Merge branch 'origin-main' into hwa/fix_deep_copy_with_template
holger-waschke Aug 10, 2026
78de602
Update template/template.go
holger-waschke Sep 8, 2026
e06c572
test(template): cover JSON and scalar rendering regressions
holger-waschke Sep 8, 2026
e9febdf
fix(template): correct indentation in DeepCopyWithTemplate function
holger-waschke Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion template/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,10 +652,16 @@ func DeepCopyWithTemplate(value any, tmplTextFunc TemplateFunc) (any, error) {
if ok == nil {
var inlineType any
err := yaml.Unmarshal([]byte(parsed), &inlineType)
if err != nil || (inlineType != nil && reflect.TypeOf(inlineType).Kind() == reflect.String) {
if err != nil {
// ignore error, thus the string is not an interface
return parsed, ok
}
if inlineString, isString := inlineType.(string); isString {
return inlineString, ok
}
if strings.TrimSpace(parsed) == "" {
return parsed, ok
}
Comment thread
holger-waschke marked this conversation as resolved.
// inlineType holds structured data decoded from the rendered string.
// This is already final data, so only normalize it into JSON-compatible
// types. It must not be passed back through DeepCopyWithTemplate, because
Expand Down
27 changes: 27 additions & 0 deletions template/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,33 @@ func TestDeepCopyWithTemplate(t *testing.T) {
fn: withSuffix,
want: "hello-templated",
},
{
title: "quoted numeric string stays string",
input: "hello",
fn: TemplateFunc(func(string) (string, error) {
return "\"123\"", nil
}),
want: "123",
},
{
title: "quoted numeric string stays string in nested map",
input: map[string]any{
"customfield_11209": map[string]any{
"id": "TOKEN",
},
},
fn: TemplateFunc(func(s string) (string, error) {
if s == "TOKEN" {
return "\"15129\"", nil
}
return s, nil
}),
want: map[string]any{
"customfield_11209": map[string]any{
"id": "15129",
},
},
},
{
title: "string parsed as YAML map",
input: "foo: bar",
Expand Down
Loading