-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement filter for remote write #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: pipiland2612 <[email protected]>
The test failed seems unrelated to my changes:
|
76a5e3a
to
3629d5c
Compare
Hm, something went wrong with #1864 (it was old PR, merged now) -- if you could fix it on the way it would epic, otherwise will fix in the incoming days... |
} | ||
}) | ||
|
||
t.Run("filter can modify message on retries", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding, but I'm wondering if the test name fully matches what we're testing here? It seems like we're only attempting once, rather than simulating retry behavior. Does that sound right, or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an idea for more realistic tests: we could implement a custom test server or modify mockStorage
to handle retry logic. This would allow us to validate code behavior against scenarios such as 'fails, retries, fails, then succeeds.' Do you feel that this make sense?
Changes