fix prometheus name check

Signed-off-by: Gregor Zeitlinger <[email protected]>

Author: zeitlinger

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/MetricMetadata.java

@@ -1,7 +1,5 @@
 package io.prometheus.metrics.model.snapshots;
 
-import io.prometheus.metrics.config.ValidationScheme;
-
 /** Immutable container for metric metadata: name, help, unit. */
 public final class MetricMetadata {
 
@@ -20,8 +18,11 @@ public final class MetricMetadata {
   private final String name;
 
   /**
-   * Same as name, except if name contains dots, then the prometheusName is {@code name.replace(".",
-   * "_")}.
+   * Same as name that all invalid char (without Unicode support) are replaced by _
+   *
+   * <p>Multiple metrics with the same prometheusName are not allowed, because they would end up in
+   * the same time series in Prometheus if {@link EscapingScheme#UNDERSCORE_ESCAPING} or {@link
+   * EscapingScheme#DOTS_ESCAPING} is used.
    */
   private final String prometheusName;
 
@@ -54,12 +55,8 @@ public MetricMetadata(String name, String help, Unit unit) {
     this.name = name;
     this.help = help;
     this.unit = unit;
+    this.prometheusName = PrometheusNaming.prometheusName(name);
     validate();
-    this.prometheusName =
-        name.contains(".")
-                && PrometheusNaming.getValidationScheme() == ValidationScheme.LEGACY_VALIDATION
-            ? PrometheusNaming.prometheusName(name)
-            : name;
   }
 
   /**

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/PrometheusNaming.java

@@ -218,7 +218,7 @@ public static String validateUnitName(String name) {
    * @return the name with dots replaced by underscores.
    */
   public static String prometheusName(String name) {
-    return name.replace(".", "_");
+    return PrometheusNaming.escapeName(name, EscapingScheme.UNDERSCORE_ESCAPING);
   }
 
   /**