Heartbeat collector query using palceholders#765
Open
malderete wants to merge 1 commit intoprometheus:mainfrom
Open
Heartbeat collector query using palceholders#765malderete wants to merge 1 commit intoprometheus:mainfrom
malderete wants to merge 1 commit intoprometheus:mainfrom
Conversation
Added argument's placeholders rather than string concatenation when using query data with non-trusted arguments (CLI inputs) Signed-off-by: Martin Alderete <malderete@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves how heartbeat generates the SQL query. Reduce the type of errors produced by "wrong" arguments.
Use argument's placeholders and QueryContext instead of using ftm.Sprintf to generate the query.
@SuperQ, can you review it please?