[FEATURE] Add fscache collector #3321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmolisch
force-pushed
the
fscache-parsing
branch
3 times, most recently
from
edb4c1a to
d8182cd
Compare
Signed-off-by: Marek Molisch <[email protected]>
Signed-off-by: Marek Molisch <[email protected]>
mmolisch
force-pushed
the
fscache-parsing
branch
2 times, most recently
from
9fa9729 to
c7239be
Compare
Signed-off-by: Marek Molisch <[email protected]>
mmolisch
force-pushed
the
fscache-parsing
branch
from
c7239be to
9c880a8
Compare
Author
|
did u just vibecoded this shit? |
SuperQ
requested changes
Oct 23, 2025
Comment on lines
+85
to
+90
| return &fscacheCollector{ | ||
| objectsAllocated: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, fscacheSubsystem, "objects_allocated_total"), | ||
| "Number of index cookies allocated (Cookies: idx=allocated/available/unused).", | ||
| nil, nil, | ||
| ), |
Member
There was a problem hiding this comment.
We're using a pattern of package level Desc vars, rather than having NewDesc() in the NewFooCollector() function. This is to avoid allocating new Desc data when using the dynamic collector module mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added collector for /proc/fs/fscache/stats