Add filesystem UUID based filter #3384
Open
+110
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjavaskivuori
force-pushed
the
erja/fs-uuid
branch
2 times, most recently
from
42adf18 to
6efaa70
Compare
erjavaskivuori
force-pushed
the
erja/fs-uuid
branch
from
6efaa70 to
9f925e6
Compare
erjavaskivuori
force-pushed
the
erja/fs-uuid
branch
from
9f925e6 to
f5bf4ab
Compare
|
@SuperQ can we have reviews on this one? |
Add filesystem UUID based filter to filesystem collector. Co-authored-by: Adam Rozman <[email protected]> Signed-off-by: erjavaskivuori <[email protected]> Signed-off-by: Adam Rozman <[email protected]>
|
@SuperQ I have took over this PR and I have also re-based it. Would it be possible to get some review on this PR? |
|
Adding @discordianfish too, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filesystem UUID based filter to the
filesystemCollectorThe implementation currently only includes Linux and I would be glad to hear feedback before continuing to implement this for other OS' file system collectors.
I tried to create unit test for the
buildUUIDMapfunction but couldn't figure out how could I create device major:minor for the fixture block device nodes that I tried to add. So currently there is no test for this feature. I have tested this locally.Fixes #3380