Drop deprecated fields + use yaml.UnmarshalStrict()#673
Open
simonhammes wants to merge 2 commits intoprometheus:masterfrom
Open
Drop deprecated fields + use yaml.UnmarshalStrict()#673simonhammes wants to merge 2 commits intoprometheus:masterfrom
yaml.UnmarshalStrict()#673simonhammes wants to merge 2 commits intoprometheus:masterfrom
Conversation
I also removed all test cases that turned out to be redundant Signed-off-by: simonhammes <simonhammes@users.noreply.github.com>
Fixes prometheus#546 Supersedes prometheus#608 Signed-off-by: simonhammes <simonhammes@users.noreply.github.com>
simonhammes
force-pushed
the
strict-config-parsing-drop-deprecated-fields
branch
from
497d016 to
ce6961d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables strict config parsing and removes all deprecated config fields (as suggested in #608 (comment)).
I also removed all test cases that turned out to be redundant.
Fixes #546