Improve return types to prevent deprecation warnings#450
Open
zluiten wants to merge 1 commit intoprooph:7.xfrom
Open
Improve return types to prevent deprecation warnings#450zluiten wants to merge 1 commit intoprooph:7.xfrom
zluiten wants to merge 1 commit intoprooph:7.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #425 the appropriate return types attributes are added to indicate that the return type will change, but because of missing doc block annotation this still generates a deprecation warning.
While at it I also changed the return type of \Prooph\EventStore\Upcasting\UpcastingIterator::current to mixed which is a broadening change. This removes the dependency on the deprecated prooph/common library. Because it's a broadening change this shouldn't cause BC issues I believe.