refactor examples structure#14
refactor examples structure#14saksham-chawla wants to merge 1 commit intocodex/replay-pr-153-basefrom
Conversation
- alias existing examples in `/examples` - add README
There was a problem hiding this comment.
One documentation fix needed to correct example build command labels after refactor.
Status: Changes Suggested | Risk: Medium | Readiness: 7/10 (Mostly Ready)
Issues Identified & Suggestions
- Update build command labels to use new aliases:
examples/README.md
Review Details
📁 4 files reviewed | 💬 1 comments
👍 / 👎 individual comments to help improve reviews for you
| ```bash | ||
| bazel build //examples/com-api-example:com-api-example | ||
| ``` | ||
|
|
||
| ### QNX Cross-Compilation | ||
|
|
||
| ```bash | ||
| bazel build --config=x86_64-qnx //examples/com-api-example:com-api-example | ||
| ``` |
There was a problem hiding this comment.
[Documentation] The build commands documented here point to a package (//examples/com-api-example:com-api-example) that does not exist in this refactor. The aliases you added in examples/BUILD are exposed as //examples:com_api_example, so users who copy these commands will get no such package 'examples/com-api-example'. Update the host and QNX build instructions to use the alias label (or the original //score/... label) so the commands actually work, e.g.:
bazel build //examples:com_api_example
bazel build --config=x86_64-qnx //examples:com_api_exampleContext for Agents
The build commands documented here point to a package (`//examples/com-api-example:com-api-example`) that does not exist in this refactor. The aliases you added in `examples/BUILD` are exposed as `//examples:com_api_example`, so users who copy these commands will get `no such package 'examples/com-api-example'`. Update the host and QNX build instructions to use the alias label (or the original `//score/...` label) so the commands actually work, e.g.:
```bash
bazel build //examples:com_api_example
bazel build --config=x86_64-qnx //examples:com_api_example
```
File: examples/README.md
Line: 22Chain of Thought
- Validation Decision: accepted
- Confidence: 0.97
- Likelihood Score: 5/5
- Likelihood Reason: The Bazel package
//examples/com-api-exampledoes not exist (no BUILD file at that path). Any user copying the documented command will get an immediate build error. - Suggested Action: keep
- Tool Calls Used: 5
Reasoning
The comment is accurate and actionable:
-
The
examples/BUILDfile defines aliases:com_api_example→//score/mw/com/example/com-api-example:com-api-example,ipc_bridge_cpp→//score/mw/com/example/ipc_bridge:ipc_bridge_cpp, etc. -
There is no
examples/com-api-example/BUILDfile in the repository, so the Bazel package//examples/com-api-exampledoes not exist. -
The README (lines 15, 21) documents
bazel build //examples/com-api-example:com-api-examplewhich will fail with "no such package". -
The correct command should be
bazel build //examples:com_api_example(using the alias). -
Notably, the IPC Bridge section (lines 81, 87) correctly uses
//examples:ipc_bridge_cpp, showing this is an inconsistency within the same new file. -
This is entirely new content introduced by this PR (the file was empty before), so this is clearly a PR-introduced issue.
The comment provides a specific fix with corrected commands. This is valid and actionable.
Evidence Summary
1. File Snapshot (HEAD)
- File:
examples/BUILD
1: # *******************************************************************************
2: # Copyright (c) 2026 Contributors to the Eclipse Foundation
3: #
4: # See the NOTICE file(s) distributed with this work for additional
5: # information regarding copyright ownership.
6: #
7: # This program and the accompanying materials are made available under the
8: # terms of the Apache License Version 2.0 which is available at
9: # https://www.apache.org/licenses/LICENSE-2.0
10: #
...
2. File Lookup
- Filename:
BUILD - Max Results:
10
Found 10 file(s) matching 'BUILD':
- bazel/rules/BUILD
- bazel/tools/BUILD
- BUILD
- quality/integration_testing/BUILD
- quality/integration_testing/environments/BUILD
- quality/integration_testing/environments/qnx8_qemu/BUILD
- quality/integration_testing/environments/ubuntu24_04_docker/BUILD
- quality/integration_testing/test/BUILD
- quality/sanitizer/BUILD
...
3. File Lookup
- Filename:
com-api-example - Max Results:
10
No files found matching 'com-api-example'
4. File Lookup
- Filename:
BUILD - Max Results:
10
Found 10 file(s) matching 'BUILD':
- bazel/rules/BUILD
- bazel/tools/BUILD
- BUILD
- quality/integration_testing/BUILD
- quality/integration_testing/environments/BUILD
- quality/integration_testing/environments/qnx8_qemu/BUILD
- quality/integration_testing/environments/ubuntu24_04_docker/BUILD
- quality/integration_testing/test/BUILD
- quality/sanitizer/BUILD
...
/examplesFollow global
module_templatestructure - examples should be in/examples.Example from
scramplerepository is the same asipc_bridge.Closes: eclipse-score/score#2539
refactor examples structure
This pull request refactors the structure of examples by consolidating them into a dedicated
/examplesdirectory, aligning with a globalmodule_templatestructure. It introduces a newBUILDfile in/examplesto create aliases for existing example targets and adds a comprehensiveREADME.mdto provide build and run instructions for theCOM-API-ExampleandIPC Bridgeapplications. Additionally, the rootREADME.mdis updated to point to this new examples directory.This summary was automatically generated by @propel-code-bot