feat: remove blacklist from fynd by Troshchk · Pull Request #128 · propeller-heads/fynd

Troshchk · 2026-03-23T18:10:58Z

Move blocklist filtering upstream. Previously, blocklisted components were received from the Tycho stream and filtered out manually in TychoFeed::handle_tycho_message. Now the blocklist is passed directly to ComponentFilter when subscribing, so blocklisted components are never sent to us.
Rename blacklist → blocklist across config files, CLI flags, builder methods, and types.
Remove blocklist unit tests from TychoFeed since the filtering no longer happens at that layer.

The blocklist filter itself lives in tycho-indexer, but blocklist.toml stays in fynd because it defines which pools fynd user considers problematic.

github-actions · 2026-03-23T18:18:19Z

Breaking API Changes (Intentional)

Breaking API changes detected and declared in the PR title.
Ensure the minor version is bumped before merging (breaking changes on 0.x.x bump the minor).

semver-checks output

Checking fynd-core v0.45.0 -> v0.45.0 (no change; assume minor)
     Checked [   0.633s] 196 checks: 195 pass, 1 fail, 0 warn, 49 skip

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron

Failed in:
  FyndBuilder::blacklisted_components, previously in file fynd-core/src/solver.rs:384
  FyndBuilder::blacklisted_components, previously in file fynd-core/src/solver.rs:384

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [   0.850s] fynd-core
    Checking fynd-rpc v0.45.0 -> v0.45.0 (no change; assume minor)
     Checked [   0.082s] 196 checks: 194 pass, 2 fail, 0 warn, 49 skip

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron

Failed in:
  FyndRPCBuilder::blacklist, previously in file fynd-rpc/src/builder.rs:142

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/struct_missing.ron

Failed in:
  struct fynd_rpc::config::BlacklistConfig, previously in file fynd-rpc/src/config.rs:72

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [   0.135s] fynd-rpc
    Checking fynd-rpc-types v0.45.0 -> v0.45.0 (no change; assume minor)
     Checked [   0.130s] 196 checks: 196 pass, 49 skip
     Summary no semver update required
    Finished [   0.260s] fynd-rpc-types
    Checking fynd-client v0.45.0 -> v0.45.0 (no change; assume minor)
     Checked [   0.150s] 196 checks: 196 pass, 49 skip
     Summary no semver update required
    Finished [   0.310s] fynd-client

louise-poole

This likely can be simplified more if the tycho-simulation is updated to take a config file directly. So far looks good though.

docs/guides/server-configuration.md

louise-poole · 2026-03-25T14:12:24Z

docs/guides/server-configuration.md

+## Blocklist config

-Exclude specific components from routing, useful for components with known simulation issues (e.g., [rebasing tokens on UniswapV3 pools](https://docs.uniswap.org/concepts/protocol/integration-issues)):
+By default, Fynd loads `blocklist.toml` from the working directory. The shipped default excludes components with known simulation issues (e.g., [rebasing tokens on UniswapV3 pools](https://docs.uniswap.org/concepts/protocol/integration-issues)). Override with `--blocklist-config`:


Maybe the default blocklist file should move to the tycho-simulation repo? As the reason it's blocklisted is because of simulation issues and not Fynd-specific issues.

Do we want to always blocklist the pools defined here? even for solver users (not Fynd)? Or are these issues only for Fynd? I think I'm missing a bit of context here

I have asked Thales and he mentioned, that the most common use cases are:

this pool is faulty, so we want to to quickly remove this pool from the calculations

user wants to avoid going through this pool - maybe they give fees to someone they don’t like, or this pool has a security flaw or doesn’t comply to any user’s internal compliance

dianacarvalho1

I'm quite confused 😬 Did you also have a look at this PR #166 ?

dianacarvalho1 · 2026-03-30T16:02:57Z

fynd-core/src/feed/tycho_feed.rs

                        self.config.min_tvl / self.config.tvl_buffer_ratio,
                        self.config.min_tvl,
+                    )
+                    .blocklist(


isn't it blocklist_components(..)? here

It is blocklist from ComponentFilter from here

dianacarvalho1 · 2026-03-30T16:03:34Z

fynd-core/src/feed/tycho_feed.rs

+                        self.config
+                            .blocklisted_components
+                            .clone(),


and shouldn't it take a file path? 😵‍💫 I'm quite confused tbh

This add components to blocklist in the ComponentFilter and it takes an iterator of the component ids.
If it makes it easier to follow, I can add components to blocklist on the ProtocolStreamBuilder level, it is basically the same.

dianacarvalho1 · 2026-03-30T16:04:11Z

fynd-core/src/solver.rs

-    /// Replaces the set of component addresses that are excluded from routing.
-    pub fn blacklisted_components(mut self, components: HashSet<String>) -> Self {
-        self.blacklisted_components = components;
+    /// Sets component IDs to exclude from the Tycho stream.


why are we keeping this here? Can you please explain the motivation in the PR description?

reviewing this is quite confusing.. we accept a file in one place and read it and then in another place we accept already a hashset? I'm really not following 😕 Can you explain please?

blocklisted_components() on FyndBuilder is the builder setter that lets callers configure which components to exclude. In build(), the value is passed to TychoFeedConfig (here), which forwards it to TychoFeed and that's where the actual filtering happens.

aaaahhh ok then AG! I was just very confused when reviewing 😵‍💫

Troshchk · 2026-03-31T13:33:34Z

I'm quite confused 😬 Did you also have a look at this PR #166 ?

I did see it and as far as I understand it was an adhoc change, that would be replaced with a change in this PR

dianacarvalho1

Looks good to me! let's just not merge this before we merge all the other related PRs and change the cargo.toml here!

Troshchk · 2026-04-01T15:03:52Z

Since we now provide a blocklist file, do we still need builtin_default()?
Also, should tycho-simulation follow the same behavior for blocklist?
@kayibal tagging you here, since you added it

Troshchk changed the title ~~feat: remove blacklist from fynd-rpc~~ feat: remove blacklist from fynd Mar 23, 2026

Troshchk force-pushed the kt/ENG-5580-add-blacklist-filter branch 3 times, most recently from 3f16269 to 3e39b64 Compare March 25, 2026 10:29

louise-poole reviewed Mar 25, 2026

View reviewed changes

docs/guides/server-configuration.md Outdated Show resolved Hide resolved

docs/guides/server-configuration.md Outdated Show resolved Hide resolved

louise-poole reviewed Mar 25, 2026

View reviewed changes

Troshchk force-pushed the kt/ENG-5580-add-blacklist-filter branch from d99168e to 471ff7b Compare March 30, 2026 10:37

dianacarvalho1 reviewed Mar 30, 2026

View reviewed changes

dianacarvalho1 approved these changes Mar 31, 2026

View reviewed changes

Ksenia Troshchenkova added 5 commits April 1, 2026 15:08

feat: move blocklist to tycho-simulation

84334b9

feat: add blocklisted_components setter to FyndBuilder

c2302d5

chore: point deps to specific commits for testing

13b1f45

chore: formatting

2cacfc8

chore: formatting

d5b93c6

Troshchk force-pushed the kt/ENG-5580-add-blacklist-filter branch from eeeb226 to d5b93c6 Compare April 1, 2026 13:18

Ksenia Troshchenkova added 3 commits April 1, 2026 15:26

chore: formatting

0d87dd4

fix: remove dependency mentioned twice from cargo.lock

bfcfcd2

chore: update dependency version

e4eb51d

dianacarvalho1 mentioned this pull request Apr 1, 2026

fix: set min token quality filter on tycho stream #176

Open

feat: add missing components to blocklist

6418f36

Troshchk force-pushed the kt/ENG-5580-add-blacklist-filter branch from ebe8789 to 6418f36 Compare April 1, 2026 15:07

Conversation

Troshchk commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking API Changes (Intentional)

Uh oh!

louise-poole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dianacarvalho1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Troshchk commented Mar 31, 2026

Uh oh!

dianacarvalho1 left a comment

Choose a reason for hiding this comment

Uh oh!

Troshchk commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Troshchk commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading