refactor: change server config to be binary-oriented#183
Open
refactor: change server config to be binary-oriented#183
Conversation
Collaborator
zizou0x
commented
Apr 3, 2026
zizou0x
commented
- Updated README and server configuration documentation to reflect the new command usage without 'cargo run --release --'.
- Changed the ENTRYPOINT in Dockerfile to make it more flexible (like the binary).
- Updated README and server configuration documentation to reflect the new command usage without 'cargo run --release --'. - Changed the ENTRYPOINT in Dockerfile to make it more flexible (like the binary).
kayibal
approved these changes
Apr 3, 2026
Contributor
kayibal
left a comment
kayibal
left a comment
There was a problem hiding this comment.
Looks better, but we need to adapt the installtion / setup instructions to actually put the fynd binary in your path. Mainly the compile from source one.
Other than this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.