fix(swagger): correct AccountUpdate.address schema type from Vec<String> to String#866
Merged
fix(swagger): correct AccountUpdate.address schema type from Vec<String> to String#866
Conversation
Addresses remaining schema issues after PR #733, and extends the test suite to catch similar regressions in the future. Key changes: - Fix AccountUpdate.address annotation from Vec<String> to String - Fix TracingResult.retriggers annotation to avoid invalid allOf in items - Remove dead commented-out derive on ComponentTvlRequestResponse - Add test_openapi_has_no_empty_schemas to catch bare {} schemas - Add test_openapi_no_tuple_allof_in_items to detect tuple allOf pattern Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…alidation" This reverts commit 4954fbf.
`Bytes` serialises as a single hex string via `hex_bytes`, not an array, so the OpenAPI annotation should be `String` not `Vec<String>`. Key changes: - Fix `#[schema(value_type=Vec<String>)]` → `#[schema(value_type=String)]` on `AccountUpdate.address` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
To run Claude review, comment |
|
This PR is included in version 0.145.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountUpdate.addressuses#[serde(with = "hex_bytes")]which serialisesBytesas a single hex string, not an array. The#[schema(value_type=Vec<String>)]annotation was mislabelled, causing Swagger UI to show the field as an array. Corrected toString.🤖 Generated with Claude Code