feat: make ProtocolStreamBuilder data source more flexible#509
Open
feat: make ProtocolStreamBuilder data source more flexible#509
Conversation
zizou0x
changed the title
zizou0x
force-pushed
the
zz/allow-stream-from-any-source
branch
from
d716064 to
e191ece
Compare
Currently most of the TychoStreamBuilder configuration is leaked on ProtocolStreamBuilder. While this makes the interface slightly cleaner, it also makes the ProtocolStreamBuilder very strict regarding the data feed. This PR aims to improve this by allowing to use a raw receiver instead of TychoStreamBuilder. This clearly separate these two structs and make the whole system more flexible, for example we can test with a custom feed. This was made in a completely backward compatible way, if we like the idea we can start deprecating the old interfaces.
zizou0x
force-pushed
the
zz/allow-stream-from-any-source
branch
from
e191ece to
5019e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently most of the TychoStreamBuilder configuration is leaked on ProtocolStreamBuilder interface. While this makes the building process slightly cleaner, it also makes the ProtocolStreamBuilder very strict regarding the data feed source. This PR aims to improve this by allowing to use a raw receiver instead of TychoStreamBuilder. This clearly separate these two structs and make the whole system more flexible, for example we can write unit tests with a custom feed.
This was made in a completely backward compatible way, if we like the idea we can start deprecating the old interfaces.