Open
Conversation
Alien Base V3 on Base uses a custom 0.075% fee tier (750) with tick_spacing=15 for blue chip pairs. Without this, pools with fee=750 fail deserialization with "Unsupported fee amount". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add doc comment to MediumLow2 variant documenting its origin and tick spacing. Add unit tests for fee=750 round-trip through TryFrom and tick_spacing=15 mapping to prevent regressions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Haikane
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Haikane
force-pushed
the
feat/alienbase-v3
branch
from
619e8a0 to
a76aa19
Compare
dianacarvalho1
approved these changes
Feb 23, 2026
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you! this looks good
tamaralipows
approved these changes
Feb 23, 2026
Comment on lines
+43
to
+47
| fn test_fee_amount_750_round_trip() { | ||
| let fee = FeeAmount::try_from(750).expect("750 should be a valid fee tier"); | ||
| assert_eq!(fee, FeeAmount::MediumLow2); | ||
| assert_eq!(fee as i32, 750); | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think these tests are very meaningful, we are essentially testing that the rust enum works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MediumLow2 = 750(0.075%) fee tier to theFeeAmountenum with tick_spacing=15InvalidSnapshotError::ValueError("Unsupported fee amount")Changes
enums.rs: AddMediumLow2 = 750variant andTryFrommatch armstate.rs: AddMediumLow2 => 15toget_spacing()Verification
cast callon Alien Base V3 factory (feeAmountTickSpacing(750))Related PRs
Test plan
cargo checkclean🤖 Generated with Claude Code