Open
Conversation
Read fee_bps from the component's static_attributes instead of using a hardcoded 30 bps constant. Default to 30 if the attribute is absent for backward compatibility with existing pools. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Prevent arithmetic underflow in fee_numerator() when fee_bps > 10000 by adding an assertion in new_with_fee() and a ValueError check in the decoder. Add tests for zero fee, max boundary, exceeds-max, missing fee default, and empty fee bytes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
Review fixes pushedAddressed findings from the multi-agent code review: Bounds validation (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fee_bpsfield toUniswapV2State(defaults to 30, serde-compatible with existing serialized states)static_attributeson the component snapshotnew_with_fee()assertsfee_bps <= 10000to prevent arithmetic underflow infee_numerator(). Decoder returnsValueErrorfor out-of-range fees.Test plan
🤖 Generated with Claude Code