Open
Conversation
MSRV is 1.91.0 which stabilizes LazyLock, removing the need for the lazy_static crate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused deps: uuid, mini-moka, lazy_static, tempfile, tracing-appender, unicode-width - Move dialoguer to dev-dependencies (example-only) - Disable chrono default features (no clock/tz needed) - Narrow tokio workspace features from "full" to only what's used - Clean up tycho-test: remove dotenv, futures, itertools, lru, num-traits, rand, tracing-subscriber, tycho-client - Clean up tycho-integration-test: remove alloy-chains, colored, serde, serde_json; add tokio signal feature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uuid,mini-moka,lazy_static,tempfile,tracing-appender,unicode-width) and movedialoguerto dev-dependencieslazy_staticwithstd::sync::LazyLock(stable since Rust 1.80, MSRV is 1.91.0)chronodefault features and narrowtokioworkspace features from"full"to only what's usedtycho-testandtycho-integration-testCargo.toml files (8 + 4 unused deps removed)Motivation
The workspace had accumulated unused dependencies and overly broad feature flags over time. This adds unnecessary compile time and dependency surface area. A clean build comparison shows:
Removing
lazy_staticin favor ofstd::sync::LazyLockalso eliminates a third-party dependency for functionality now in the standard library.Test plan
cargo +nightly fmt --all --checkcargo clippy --workspace --lib --all-targets --all-features -- -D clippy::dbg-macro(RUSTFLAGS=-Dwarnings)cargo check --no-default-features(RUSTFLAGS=-Dwarnings)cargo nextest run --workspace --lib --all-targets --all-features— 595 passed🤖 Generated with Claude Code