perf: Optimize ObjectBuilder to eliminate N+1 table lookups during code generation#2058
Open
Ayoub-Mabrouk wants to merge 1 commit intopropelorm:masterfrom
Open
Conversation
…de generation Optimize the ObjectBuilder class to reduce redundant getTable() calls in nested loops by pre fetching and caching referenced tables before iteration. This reduces complexity from O(N×M) to O(N+M) where N is the number of columns and M is the number of foreign keys per column.
|
je demandais si tu t'avais abonné a Propel 2 sur git hubEnvoyé depuis mon appareil Galaxy
-------- Message d'origine --------De : Ayoub Mabrouk ***@***.***> Date : 2025-12-22 11 h 03 a.m. (GMT-05:00) À : propelorm/Propel2 ***@***.***> Cc : Subscribed ***@***.***> Objet : [propelorm/Propel2] perf: Optimize ObjectBuilder to eliminate N+1 table lookups during code generation (PR #2058) Optimize the ObjectBuilder class to reduce redundant getTable() calls in nested loops by pre fetching and caching referenced tables before iteration.
This reduces complexity from O(N×M) to O(N+M) where N is the number of columns and M is the number of foreign keys per column.
You can view, comment on, or merge this pull request online at:
#2058
Commit Summary
891d640 perf: Optimize ObjectBuilder to eliminate N+1 table lookups during code generation
File Changes (1 file)
M
src/Propel/Generator/Builder/Om/ObjectBuilder.php
(40)
Patch Links:
https://github.com/propelorm/Propel2/pull/2058.patch
https://github.com/propelorm/Propel2/pull/2058.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#2058",
"url": "#2058",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the ObjectBuilder class to reduce redundant getTable() calls in nested loops by pre fetching and caching referenced tables before iteration.
This reduces complexity from O(N×M) to O(N+M) where N is the number of columns and M is the number of foreign keys per column.