feat: define core TypeScript types #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Experience interface with targeting and content - Add Decision interface with reasons and trace (explainability) - Add Context interface for evaluation input - Add ExperienceConfig and RuntimeState interfaces - Full JSDoc documentation for all types - All types exported and typecheck passing Closes #1
- Follow sdk-kit pattern: any is intentional for public APIs - Set noExplicitAny to 'warn' globally - Disable for types.ts and runtime.ts (public API surfaces) - Disable for test files - Update documentation to explain any usage pattern - Keep any for config values, event payloads, custom user data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements all core TypeScript type definitions for the Experience SDK.
Changes
Acceptance Criteria
Experienceinterface definedTargetingRulesinterfaces definedDecisioninterface defined (with reasons & trace)Contextinterface definedExperienceConfiginterface definedpnpm typecheckpassesCloses #1