Conversation
- replace javax.inject.Provider usage - add jakarta.inject-api dependency
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d159df4be7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <id>docker-build</id> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>docker</executable> | ||
| <workingDirectory>${project.basedir}</workingDirectory> |
There was a problem hiding this comment.
Binding the exec-maven-plugin to the default package and install phases makes every mvn package / mvn install invoke docker build/docker push. In environments without a Docker daemon or registry credentials (common in dev machines and CI runners), these phases will now fail even when only building the JAR, which is a regression from prior behavior. Consider moving these executions behind a profile or a property-controlled skip so the default build remains Docker-free.
Useful? React with 👍 / 👎.
1 participant
replace javax.inject.Provider usage
add jakarta.inject-api dependency