Skip to content

Refactor injection token definitions for dynamic keys #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpanic merged 2 commits into from
Jan 31, 2025
Merged

Refactor injection token definitions for dynamic keys #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f0d2f7
Refactor injection token definitions to use dynamic property keys
joaosreis Jan 20, 2025
99aafd8
Add comment
joaosreis Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/protocol/src/protocol/Protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,16 @@ import { ProvableTransactionHook } from "./ProvableTransactionHook";
import { ProtocolEnvironment } from "./ProtocolEnvironment";
import { ProvableBlockHook } from "./ProvableBlockHook";

/**
* This is a mapping of abstract classes to their respective injection tokens.
* Keys are the abstract classes names, which need to be set dynamically
* and can't be hardcoded since producing optimized builds may mangle the
* class names, making them different from the ones in the source code.
*/
const PROTOCOL_INJECTION_TOKENS: Record<string, string> = {
ProvableTransactionHook: "ProvableTransactionHook",
ProvableBlockHook: "ProvableBlockHook",
ProvableSettlementHook: "ProvableSettlementHook",
[ProvableTransactionHook.name]: "ProvableTransactionHook",
[ProvableBlockHook.name]: "ProvableBlockHook",
[ProvableSettlementHook.name]: "ProvableSettlementHook",
};

export type ProtocolModulesRecord = ModulesRecord<
Expand Down Expand Up @@ -161,7 +167,7 @@ export class Protocol<

implementingModules.forEach(([key]) => {
this.container.register(
abstractType.name,
newInjectionToken,
{ useToken: key },
{ lifecycle: Lifecycle.ContainerScoped }
);
Expand All @@ -174,7 +180,7 @@ export class Protocol<

// Register default (noop) version
this.container.register(
abstractType.name,
newInjectionToken,
{ useClass: defaultType },
{ lifecycle: Lifecycle.ContainerScoped }
);
Expand Down
Loading