Add sequencer id to job payloads #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raunaque97
force-pushed
the
raun/addSequencerID
branch
from
8e112ff to
ddf7607
Compare
rpanic
reviewed
Nov 14, 2025
packages/sequencer/test/protocol/production/flow/ReductionTaskFlow.test.ts
Outdated
Show resolved
Hide resolved
removed .vscode/launch.json
Raunaque97
force-pushed
the
raun/addSequencerID
branch
from
fcd0764 to
19c7716
Compare
rpanic
approved these changes
Nov 18, 2025
Member
rpanic
left a comment
rpanic
left a comment
There was a problem hiding this comment.
Approved given fix of the one new comment
|
|
||
| // Drain all task queues to clear stale tasks from previous sequencer instances | ||
| if (this.container.isRegistered("TaskQueue")) { | ||
| const taskQueue = this.container.resolve<TaskQueue>("TaskQueue"); |
Member
There was a problem hiding this comment.
I thought I added a comment here but apparently didn't (please say if we already talked about it).
But I'd much rather see this logic here implemented in the start() function that the TaskQueue implements (SequencerModule requires that anyways, and it is automatically called by the sequencer during startup)
Raunaque97
force-pushed
the
raun/addSequencerID
branch
from
6ba3389 to
045455f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unique
sequencer.idto a sequencer instance and includes it in all task payloads.So the Flow class can now filters out responses from old sequencer instances.
Fixes #314