Merged
Conversation
Signed-off-by: Adolfo Garcia Veytia (puerco) <adolfo.garcia@uservers.net>
This commit reworks the data access paths to the protobom data to ensure the CEL environment can access the protobom properties. To do so we start introducing new types for the protobom elements and reworked the type adapter which is now weaved throughout the CEL api functions. Signed-off-by: Adolfo Garcia Veytia (puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo Garcia Veytia (puerco) <puerco@carabiner.dev>
cpanato
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the second big chunk of changes required to get the protobom CEL integration to a sufficiently general purpose state. We now have a refactored the data type adapter which is wired it through the code, meaning it is effectively in use now.
The second change is that the API functions have been normalized to follow CEL conventions: lowercase and using snake case. After this PR we should be able to start cutting early releases as it should be in a good enough state to import into other tools.
Signed-off-by: Adolfo Garcia Veytia (puerco) puerco@carabiner.dev