Skip to content

Remove jsdoc includePattern #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshkel
Copy link

@joshkel joshkel commented Aug 1, 2025

As explained at https://jsdoc.app/about-configuring-jsdoc#specifying-input-files, jsdoc uses a default includePattern of ".+\.js(doc|x)?$" and filters out files (even files explicitly given on the command line) that do not match this pattern.

pbts always runs on a single, explicitly given file, so it should disable includePattern.

Fixes #2088

As explained at https://jsdoc.app/about-configuring-jsdoc#specifying-input-files, jsdoc uses a default includePattern of ".+\\.js(doc|x)?$" and filters out files (even files explicitly given on the command line) that do not match this pattern.

pbts always runs on a single, explicitly given file, so it should disable includePattern.

Fixes protobufjs#2088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running pbts on non-.js extensions fails
1 participant