-
Notifications
You must be signed in to change notification settings - Fork 5
Add Issue Labels #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Stebalien
wants to merge
5
commits into
main
Choose a base branch
from
feat/issue-labeling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Issue Labels #90
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ecd7db0
feat: add web3 labeling standards
Stebalien 46f9f63
ci: add label check script
Stebalien a477060
add a check-labels action
Stebalien 30adcdd
fix: remove proposal that shouldn't be in this PR
Stebalien c46cb00
labels: split off cleanup from maintenance
Stebalien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#!/bin/bash | ||
# | ||
# This script checks the local label table (ISSUE_LABELS.md) against canonical label file in the | ||
# protocol/.github repo. | ||
|
||
set -euo pipefail | ||
set -x | ||
|
||
# The canonical source of labels. | ||
CANONICAl_LABELS="https://raw.githubusercontent.com/protocol/.github/master/ISSUE_LABELS.json" | ||
|
||
# Matches labels in label tables. Assumes table rows have the form: | ||
# | `label name` | Some description... | ...`#hexcolor`... | | ||
LABEL_REGEXP='s/|.*`\([^`]*\)`.*| *\([^|]*[^ |]\) *|.*`\(#[a-f0-9]*\)`.*|/\1\t\3\t\2/p' | ||
|
||
# Reads a label markdown file on stdin and prints a JSON version on stdout. | ||
parse_labels() { | ||
while IFS=$'\t' read -r label color description; do | ||
jq -n \ | ||
--arg name "$label" \ | ||
--arg color "${color##\#}" \ | ||
--arg description "$description" \ | ||
'{"name": $name, "color": $color, "description": $description}' | ||
done < <(sed -ne "$LABEL_REGEXP" - ) | | ||
jq 'select(.name | startswith("area/") == false)' | # area labels are not synced. | ||
jq -s 'sort_by(.name)' # sort into a canonical order for comparison. | ||
} | ||
|
||
# Extract labels. | ||
parse_labels < ISSUE_LABELS.md > ISSUE_LABELS.json | ||
|
||
# Download canonical labels. | ||
curl "$CANONICAl_LABELS" | | ||
jq 'del(.aliases)|sort_by(.name)' > CANONICAL_LABELS.json | ||
|
||
# Compare. | ||
if ! diff -u CANONICAL_LABELS.json ISSUE_LABELS.json; then | ||
echo "Please update the labels defined at https://github.com/protocol/.github/blob/master/ISSUE_LABELS.json." | ||
exit 1 | ||
fi | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
on: | ||
push: | ||
branches: | ||
- main | ||
paths: | ||
- 'ISSUE_LABELS.md' | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
- 'ISSUE_LABELS.md' | ||
name: Check Issue Labels | ||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Check Labels | ||
run: | | ||
./.github/scripts/check-labels.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
# W3DT issue labeling standards | ||
|
||
The W3DT org standardizes on the following default core labels for GitHub issues and pull requests. This ensures continuity | ||
between repos, helping to improve the overall experience for contributors as a whole while also making it easier to use project | ||
planning tools (such as ZenHub) to create landscape-level views across multiple repos. | ||
|
||
## Mandatory labels | ||
|
||
### Global | ||
These are exceptions to the remainder of this labeling taxonomy, but exist for continuity with global GitHub practices for new contributors. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `bounty` | Has bounty! See https://github.com/ipfs/devgrants/projects/1 | `#1cfc60` | | ||
| `good first issue` | Good issue for new contributors | `#7057ff` | | ||
| `help wanted` | Seeking public contribution on this issue | `#0e8a16` | | ||
|
||
### Priority | ||
Indicates priority as a function of standard PL-wide OKR priority rankings. **Important: P0 items need an assignee to act as a DRI.** | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `P0` | Critical: Tackled by core team ASAP | `#b60205` | | ||
| `P1` | High: Likely tackled by core team if no one steps up | `#d93f0b` | | ||
| `P2` | Medium: Good to have, but can wait until someone steps up | `#e99695` | | ||
| `P3` | Low: Not priority right now | `#f9d0c4` | | ||
|
||
### Kind | ||
Overarching type of issue or PR. For an additional layer of specificity, use the `area` label. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `kind/architecture` | Core architecture of project | `#c7def8` | | ||
| `kind/bug` | A bug in existing code (including security flaws) | `#fc2929` | | ||
| `kind/discussion` | Topical discussion; usually not changes to codebase | `#c7def8` | | ||
| `kind/enhancement` | A net-new feature or improvement to an existing feature | `#c7def8` | | ||
| `kind/maintenance` | Work required to avoid breaking changes or harm to project's status quo | `#c7def8` | | ||
| `kind/support` | A question or request for support | `#c7def8` | | ||
| `kind/test` | Testing work | `#c7def8` | | ||
|
||
### Need | ||
These labels indicate needs that must be met in order for the issue or PR to be completed and closed. These will often appear in conjunction with `status/blocked` to add a layer of specificity to the latter. **Important: ALL new issues in a repo should default to `need/triage`, and this label should be removed once all other relevant labels are assigned.** | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `need/analysis` | Needs further analysis before proceeding | `#ededed` | | ||
| `need/author-input` | Needs input from the original author | `#ededed` | | ||
| `need/community-input` | Needs input from the wider community | `#ededed` | | ||
| `need/maintainer-input` | Needs input from the current maintainer(s) | `#ededed` | | ||
| `need/triage` | Needs initial labeling and prioritization | `#ededed` | | ||
|
||
## Optional (but helpful) labels | ||
|
||
### Expertise | ||
Estimate of required experience to solve the issue; note that this is different than `effort`, below. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `exp/beginner` | Can be confidently tackled by newcomers | `#bfe5bf` | | ||
| `exp/novice` | Someone with a little familiarity can pick up | `#bfe5bf` | | ||
| `exp/intermediate` | Prior experience is likely helpful | `#bfe5bf` | | ||
| `exp/expert` | Having worked on the specific codebase is important | `#bfe5bf` | | ||
| `exp/wizard` | Extensive knowledge (implications, ramifications) required | `#bfe5bf` | | ||
|
||
### Effort | ||
Similar to T-shirt sizing, this estimates the *amount* of work. This can be different than `expertise`, e.g. something can be easy but require a lot of time to complete, or vice versa. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `effort/hours` | Estimated to take one or several hours | `#fef2c0` | | ||
| `effort/days` | Estimated to take multiple days, but less than a week | `#fef2c0` | | ||
| `effort/weeks` | Estimated to take multiple weeks | `#fef2c0` | | ||
|
||
### Status | ||
Current status of the issue or PR. Note that it may be advantageous to add second-tier variants on `status/blocked` to your repo if there are common blocking scenarios, i.e. `status/blocked/upstream-bug`. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `status/blocked` | Unable to be worked further until needs are met | `#b52ed1` | | ||
| `status/inactive` | No significant work in the previous month | `#dcc8e0` | | ||
| `status/in-progress` | In progress | `#dcc8e0` | | ||
| `status/ready` | Ready to be worked | `#dcc8e0` | | ||
|
||
### Topics | ||
Topics will vary according to the particular project, but will often have commonalities that overlay across multiple projects. Design is one prominent example of this, particularly since the following design labels are used to generate a common design tracking board: | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `topic/design-content` | Content design, writing, information architecture | `#3f4b56` | | ||
| `topic/design-front-end` | Front-end implementation of UX/UI work | `#3f4b56` | | ||
| `topic/design-ux` | UX strategy, research, not solely visual design | `#3f4b56` | | ||
| `topic/design-video` | Video and/or motion design | `#3f4b56` | | ||
| `topic/design-visual` | Visual design ONLY, not part of a larger UX effort | `#3f4b56` | | ||
|
||
We also use topics to track platform specific issues: | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `topic/windows` | Windows specific issues | `#3f4b56` | | ||
| `topic/macos` | MacOS specific issues | `#3f4b56` | | ||
| `topic/linux` | Linux specific issues | `#3f4b56` | | ||
|
||
Other commonly encountered topics across multiple repos include: | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `topic/devexp` | Developer Experience | `#3f4b56` | | ||
| `topic/docs` | Documentation | `#3f4b56` | | ||
| `topic/infra` | Infrastructure | `#3f4b56` | | ||
| `topic/interop` | Interoperability | `#3f4b56` | | ||
| `topic/perf` | Performance | `#3f4b56` | | ||
| `topic/dependencies` | Dependencies | `#3f4b56` | | ||
| `topic/ci` | Continuous integration | `#3f4b56` | | ||
|
||
### Area | ||
Areas will vary depending on the needs of the particular repo, but refer to a commonly-encountered functional or abstraction layer for a project. They take the following form, where *foo* is a project-specific functional or abstraction layer, e.g. *firefox* or *libp2p*. | ||
|
||
| Label | Description | Color | | ||
| ----- | ----------- | ----- | | ||
| `area/foo` | *Area-specific description to go here* | `#ccf0ed` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
# Automated integration testing & test vector extraction | ||
Stebalien marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Authors: <!-- List authors' GitHub or other handles --> | ||
|
||
Initial PR: TBD <!-- Reference the PR first proposing this document. Oooh, self-reference! --> | ||
|
||
## Purpose & impact | ||
#### Background & intent | ||
_Describe the desired state of the world after this project? Why does that matter?_ | ||
<!-- | ||
Outline the status quo, including any relevant context on the problem you’re seeing that this project should solve. Wherever possible, include pains or problems that you’ve seen users experience to help motivate why solving this problem works towards top-line objectives. | ||
--> | ||
|
||
We currently have: | ||
|
||
1. A calibration network and some dev networks where we can test specific operations. | ||
2. Unit tests in lotus & specs-actors. | ||
|
||
However, we don't have: | ||
|
||
1. An automated and fully integrated way to test lotus end-to-end. | ||
2. An easy way to extract comprehensive test vectors after making changes to actors. | ||
|
||
This makes it difficult for to make consensus breaking changes then test their correctness on both | ||
lotus and other implementations. | ||
|
||
Proposal: | ||
|
||
1. Setup a continuously deployed (from master) dev-net for lotus that quickly upgrades to the _latest_ network version. | ||
2. Implement a set of automated test scripts (seal, terminate, mark faulty, recover, make deals, etc.). | ||
3. Automatically extract test vectors from this network and store them in a repo somewhere. | ||
|
||
This | ||
|
||
#### Assumptions & hypotheses | ||
_What must be true for this project to matter?_ | ||
<!--(bullet list)--> | ||
|
||
#### User workflow example | ||
_How would a developer or user use this new capability?_ | ||
<!--(short paragraph)--> | ||
|
||
#### Impact | ||
_How would this directly contribute to web3 dev stack product-market fit?_ | ||
|
||
<!-- | ||
Explain how this addresses known challenges or opportunities. | ||
What awesome potential impact/outcomes/results will we see if we nail this project? | ||
--> | ||
|
||
#### Leverage | ||
_How much would nailing this project improve our knowledge and ability to execute future projects?_ | ||
|
||
<!-- | ||
Explain the opportunity or leverage point for our subsequent velocity/impact (e.g. by speeding up development, enabling more contributors, etc) | ||
--> | ||
|
||
#### Confidence | ||
_How sure are we that this impact would be realized? Label from [this scale](https://medium.com/@nimay/inside-product-introduction-to-feature-priority-using-ice-impact-confidence-ease-and-gist-5180434e5b15)_. | ||
|
||
<!--Explain why this rating--> | ||
|
||
|
||
## Project definition | ||
#### Brief plan of attack | ||
|
||
<!--Briefly describe the milestones/steps/work needed for this project--> | ||
|
||
#### What does done look like? | ||
_What specific deliverables should completed to consider this project done?_ | ||
|
||
#### What does success look like? | ||
_Success means impact. How will we know we did the right thing?_ | ||
|
||
<!-- | ||
Provide success criteria. These might include particular metrics, desired changes in the types of bug reports being filed, desired changes in qualitative user feedback (measured via surveys, etc), etc. | ||
--> | ||
|
||
#### Counterpoints & pre-mortem | ||
_Why might this project be lower impact than expected? How could this project fail to complete, or fail to be successful?_ | ||
|
||
#### Alternatives | ||
_How might this project’s intent be realized in other ways (other than this project proposal)? What other potential solutions can address the same need?_ | ||
|
||
#### Dependencies/prerequisites | ||
<!--List any other projects that are dependencies/prerequisites for this project that is being pitched.--> | ||
|
||
#### Future opportunities | ||
<!--What future projects/opportunities could this project enable?--> | ||
|
||
## Required resources | ||
|
||
#### Effort estimate | ||
<!--T-shirt size rating of the size of the project. If the project might require external collaborators/teams, please note in the roles/skills section below). | ||
For a team of 3-5 people with the appropriate skills: | ||
- Small, 1-2 weeks | ||
- Medium, 3-5 weeks | ||
- Large, 6-10 weeks | ||
- XLarge, >10 weeks | ||
Describe any choices and uncertainty in this scope estimate. (E.g. Uncertainty in the scope until design work is complete, low uncertainty in execution thereafter.) | ||
--> | ||
|
||
#### Roles / skills needed | ||
<!--Describe the knowledge/skill-sets and team that are needed for this project (e.g. PM, docs, protocol or library expertise, design expertise, etc.). If this project could be externalized to the community or a team outside PL's direct employment, please note that here.--> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were we going to add a note to be more specific here? Maybe something about "Build systems, dependency upgrades, CI."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The current description better describes "tech debt" which probably deserves a different label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to split this into:
kind/maintenance
: CI, labeling, permissions.kind/cleanup
(orkind/debt
): Cleanup, refactors, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!