Skip to content

Remove unused header inclusion #24127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused header inclusion #24127

wants to merge 1 commit into from

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Oct 23, 2025

Remove unused header inclusion in the c++ sources.

@cyyever cyyever requested review from a team as code owners October 23, 2025 11:23
@cyyever cyyever requested review from dmaclach, ericsalo, jskeet and shaod2 and removed request for a team October 23, 2025 11:23
@cyyever cyyever force-pushed the unused_inclusion branch 2 times, most recently from 6c52446 to cb0b3be Compare October 23, 2025 11:59
@thomasvl thomasvl removed the request for review from dmaclach October 23, 2025 12:39
@cyyever
Remove unused header inclusion
302c8c0 
Signed-off-by: Yuanyuan Chen <[email protected]>
@honglooker honglooker added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 23, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 23, 2025
@honglooker honglooker added the c++ label Oct 23, 2025
shaod2
shaod2 reviewed Oct 24, 2025
View reviewed changes
Copy link
Member

@shaod2 shaod2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid a number of these includes are used google-internally as they're not stripped off cleanly. We could give it a try, but it can take a few iterations to merge this PR into google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaod2 shaod2 shaod2 left review comments

@ericsalo ericsalo Awaiting requested review from ericsalo ericsalo is a code owner automatically assigned from protocolbuffers/protobuf-python

@jskeet jskeet Awaiting requested review from jskeet jskeet is a code owner automatically assigned from protocolbuffers/protobuf-csharp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyever @shaod2 @honglooker