Skip to content

Conversation

@tomas-molina
Copy link
Contributor

Update options to support ranges for Thermo Fisher Scientific TEM grpc interfaces.

Update options to support ranges for Thermo Fisher Scientific TEM grpc interfaces.
@tomas-molina tomas-molina requested a review from a team as a code owner November 17, 2025 10:54
@tomas-molina tomas-molina requested review from Logofile and removed request for a team November 17, 2025 10:54
Copy link

@hans-denboer hans-denboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indicate which number has been given out already and to whom. Probably good to have a table with the number, the API and perhaps a representative name (not sure though; difficult to maintain).

@johan-groenenboom
Copy link

Please indicate which number has been given out already and to whom. Probably good to have a table with the number, the API and perhaps a representative name (not sure though; difficult to maintain).

This will be a local TFS administration rather than something we can do here?

@Logofile Logofile requested review from googleberg and removed request for Logofile November 18, 2025 13:10
@johan-groenenboom
Copy link

johan-groenenboom commented Nov 24, 2025

Hi @googleberg Jerry, would you have time to have a look at this PR?
It doesn't change any code, just documentation to reserve some options numbers.
Thanks! Best regards, Johan G.

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 3, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 3, 2025
@tomas-molina
Copy link
Contributor Author

@zhangskz @googleberg can this be merged now?

@googleberg googleberg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 5, 2026
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 5, 2026
@googleberg
Copy link
Member

@tomas-molina while this isn't changing any logic, the automatic merge is blocked by failing tests. Maybe rebase and we try again?

@zhangskz
Copy link
Member

zhangskz commented Jan 5, 2026

Triggered import for this manually -- please give this a ping if you don't see any movement.

copybara-service bot pushed a commit that referenced this pull request Jan 5, 2026
Update options to support ranges for Thermo Fisher Scientific TEM grpc interfaces.

Closes #24491

COPYBARA_INTEGRATE_REVIEW=#24491 from tomas-molina:update_tfs_options c9c27bb
FUTURE_COPYBARA_INTEGRATE_REVIEW=#24491 from tomas-molina:update_tfs_options c9c27bb
PiperOrigin-RevId: 852368371
copybara-service bot pushed a commit that referenced this pull request Jan 5, 2026
Update options to support ranges for Thermo Fisher Scientific TEM grpc interfaces.

Closes #24491

COPYBARA_INTEGRATE_REVIEW=#24491 from tomas-molina:update_tfs_options c9c27bb
FUTURE_COPYBARA_INTEGRATE_REVIEW=#24491 from tomas-molina:update_tfs_options c9c27bb
PiperOrigin-RevId: 852368371
@copybara-service copybara-service bot closed this in 6a8c2aa Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants