Skip to content

Support Ruby 4.0 #25051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frederikspang wants to merge 1 commit into from
Closed

Support Ruby 4.0 #25051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions .github/workflows/test_ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ jobs:
include:
# Test both FFI and Native implementations on the highest and lowest
# Ruby versions for CRuby and JRuby
- { name: Ruby 3.1, ruby: ruby-3.1.6, ffi: NATIVE }
- { name: Ruby 3.1, ruby: ruby-3.1.6, ffi: FFI }
- { name: Ruby 3.2, ruby: ruby-3.2.6, continuous-only: true }
- { name: Ruby 3.3, ruby: ruby-3.3.6, continuous-only: true }
- { name: Ruby 3.4, ruby: ruby-3.4.1, ffi: NATIVE }
- { name: Ruby 3.4, ruby: ruby-3.4.1, ffi: FFI }
- { name: Ruby 3.1, ruby: ruby-3.1.7, ffi: NATIVE }
- { name: Ruby 3.1, ruby: ruby-3.1.7, ffi: FFI }
- { name: Ruby 3.2, ruby: ruby-3.2.9, continuous-only: true }
- { name: Ruby 3.3, ruby: ruby-3.3.10, continuous-only: true }
- { name: Ruby 3.4, ruby: ruby-3.4.8, ffi: NATIVE }
- { name: Ruby 3.4, ruby: ruby-3.4.8, ffi: FFI }
- { name: Ruby 4.0, ruby: ruby-4.0.0, ffi: NATIVE }
- { name: Ruby 4.0, ruby: ruby-4.0.0, ffi: FFI }
- { name: JRuby 9.4, ruby: jruby-9.4.9.0, ffi: NATIVE }
- { name: JRuby 9.4, ruby: jruby-9.4.9.0, ffi: FFI }

Expand Down Expand Up @@ -143,6 +145,8 @@ jobs:
- { version: "3.3", continuous-only: true }
- { version: "3.4", ffi: NATIVE }
- { version: "3.4", ffi: FFI }
- { version: "4.0", ffi: NATIVE }
- { version: "4.0", ffi: FFI }

name: ${{ matrix.continuous-only && inputs.continuous-prefix || '' }} MacOS Ruby ${{ matrix.version }}${{ matrix.ffi == 'FFI' && ' FFI' || '' }}
runs-on: macos-14
Expand All @@ -155,7 +159,7 @@ jobs:

- name: Pin Ruby version
if: ${{ !matrix.continuous-only || inputs.continuous-run }}
uses: ruby/setup-ruby@4a9ddd6f338a97768b8006bf671dfbad383215f4 # v1.207.0
uses: ruby/setup-ruby@ae195bbe749a7cef685ac729197124a48305c1cb # v1.276.0
with:
ruby-version: ${{ matrix.version }}

Expand All @@ -180,12 +184,14 @@ jobs:
include:
# Test both FFI and Native implementations on the highest and lowest
# Ruby versions for CRuby and JRuby.
- { name: Ruby 3.1, ruby: ruby-3.1.6, ffi: NATIVE }
- { name: Ruby 3.1, ruby: ruby-3.1.6, ffi: FFI }
- { name: Ruby 3.2, ruby: ruby-3.2.6, continuous-only: true}
- { name: Ruby 3.3, ruby: ruby-3.3.6, continuous-only: true}
- { name: Ruby 3.4, ruby: ruby-3.4.1, ffi: NATIVE }
- { name: Ruby 3.4, ruby: ruby-3.4.1, ffi: FFI, continuous-only: true }
- { name: Ruby 3.1, ruby: ruby-3.1.7, ffi: NATIVE }
- { name: Ruby 3.1, ruby: ruby-3.1.7, ffi: FFI }
- { name: Ruby 3.2, ruby: ruby-3.2.9, continuous-only: true}
- { name: Ruby 3.3, ruby: ruby-3.3.10, continuous-only: true}
- { name: Ruby 3.4, ruby: ruby-3.4.8, ffi: NATIVE }
- { name: Ruby 3.4, ruby: ruby-3.4.8, ffi: FFI, continuous-only: true }
- { name: Ruby 4.0, ruby: ruby-4.0.0, ffi: NATIVE }
- { name: Ruby 4.0, ruby: ruby-4.0.0, ffi: FFI, continuous-only: true }
- { name: JRuby 9.4, ruby: jruby-9.4.9.0, ffi: NATIVE }
- { name: JRuby 9.4, ruby: jruby-9.4.9.0, ffi: FFI, continuous-only: true }
name: ${{ matrix.continuous-only && inputs.continuous-prefix || '' }} Install ${{ matrix.name }}${{ matrix.ffi == 'FFI' && ' FFI' || '' }}
Expand Down
3 changes: 3 additions & 0 deletions ruby/tests/repeated_field_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ def test_acts_like_an_array
arr_methods -= [:intersect?]
# ruby 3.4 methods we ignore
arr_methods -= [:fetch_values]
# ruby 4.0 methods we ignore
arr_methods -= [:rfind]

arr_methods.each do |method_name|
assert_respond_to m.repeated_string, method_name
end
Expand Down
Loading