Migrate POI kind and kindDetail assigment from plain Java to MultiExpression rules #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some kind=other slipping through
wipfli
reviewed
Dec 28, 2025
Collaborator
wipfli
left a comment
wipfli
left a comment
There was a problem hiding this comment.
Thanks for this pull request. At first sight it looks good. Do you also plan to move the minZoom to the MultiExpressions?
Comment on lines
77
to
90
| Expression.or( | ||
| with("landuse", "forest"), | ||
| Expression.and(with("boundary", "national_park"), with_operator_usfs), | ||
| Expression.and( | ||
| with("boundary", "national_park"), | ||
| with("protect_class", "6"), | ||
| with("protection_title", "National Forest") | ||
| ), | ||
| Expression.and( | ||
| with("boundary", "protected_area"), | ||
| with("protect_class", "6"), | ||
| with_operator_usfs | ||
| ) | ||
| ), |
Collaborator
There was a problem hiding this comment.
I have not though about this use case for the with function. But if it works I guess it is very convenient! cc @msbarry
Contributor
Author
Yes, I have a followup PR in the works for zooms but it’s much larger so I wanted to be sure that the basic ideas in this one are correct before proposing it. |
|
bdon
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from plain Java conditionals to MultiExpression rules when applying POI
kindandkindDetail. Removes some dense logic fromprocessOsm(), passes all existing tests with no changes required.