Open
Conversation
provencher
requested changes
Aug 4, 2020
Owner
provencher
left a comment
There was a problem hiding this comment.
Thanks for the PR Roger.
My preference for the time being is to avoid overtly migrating this project to place a hard dependency on XR SDK, and instead add some logic in the MRTK Config that make the necessary changes at runtime to support XRSDK, according to the project settings the code is loaded up in.
As far as a I know, the only change needed for support within the MRTK-Quest Core unitypackage, is to add a TrackedPoseDriver component to the main camera.
In fact, MRTK-Quest uses the main camera already in the scene by default, and simply reparents it into the Oculus Rig at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated some project settings to account for the new XRSDK support in mainline MRTK