-
Notifications
You must be signed in to change notification settings - Fork 23
add rv3028 to requirements #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mikefly123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work putting this together Davit!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some new errors in the flight control board. Thoughts on these?
{"hardware_key": "RTC", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:55", "level": "DEBUG"}
{"time": "2020-01-01 00:01:55", "level": "ERROR", "err": ["'I2C' object has no attribute 'write'"], "hardware_key": "RTC", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "SD Card", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:55", "level": "DEBUG"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["no SD card"], "hardware_key": "SD Card", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "NEOPIX", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:57", "level": "DEBUG"}
{"hardware_key": "TCA", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:57", "level": "DEBUG"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face0", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face1", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face2", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face3", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face4", "msg": "There was an Exception during the scan_tca_channels function call"}
For reference here's what main looks like:
{"hardware_key": "RTC", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:07", "level": "DEBUG"}
{"hardware_key": "SD Card", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:07", "level": "DEBUG"}
{"time": "2020-01-01 00:05:09", "level": "ERROR", "err": ["no SD card"], "hardware_key": "SD Card", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "NEOPIX", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"hardware_key": "TCA", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"msg": "TCA try_lock failed. TCA may be malfunctioning.", "time": "2020-01-01 00:05:09", "level": "ERROR"}
{"msg": "PySquared Hardware Initialization Complete!", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"time": "2020-01-01 00:05:09", "device": "I2C0", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "SPI0", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "I2C1", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "UART", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "Radio1", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "IMU", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "Mag", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "SDcard", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "NEOPIX", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "WDT", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "TCA", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face0", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face1", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face2", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face3", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face4", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "RTC", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
|
Good catch @nateinaction I didn't actually have a board to run the code on as a test until a few minutes ago. I ran some tests myself and have a PR for fixing this issue as #7 on the We should probably block this merge for now until it is addressed. |
|
The new release of the rv3028 library fixes this issue! This is what it looks like now: |



Summary
This PR adds the proves-circuitpython-rv3028 repository as a library to the circuitpy-flight-software code. This PR will be ready once this pull request is approved and merged.
How was this tested
The code implemented by the rv3028 was tested with unit tests prior to submitting the PR. In addition, the library was brought on to this repository locally and tested on hardware, with no issues. The rv3028 library is successfully brought in with
makeand runs fine on the board.