Event Listening Capability Added#4
Open
LucaCoduriV wants to merge 3 commits intoprovokateurin:mainfrom
Open
Conversation
Owner
|
Can you keep this PR to the fix and create two separate PRs for the other two commits? |
Author
Never done this at this state, I'll try. |
LucaCoduriV
changed the title
Author
|
A made an other PR for @FlafyDev fixes, but for my two other commits I'll keep it under the same PR because it's the same subject. I realized later that we could also listen for Player mount and unmount events that's why there is 2 commits. |
Author
|
@provokateurin Any news ? |
Owner
|
Sorry, I'm currently sick and will review next week. |
Author
|
Hi, I'm just writing in case you forgot |
Owner
|
Thanks, it's still on my todo list. I will have a look soon, but since I wrote most of this code years ago it will take me some time to test and review everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've augmented the functionality to enable listening to a diverse range of events such as volume adjustments, play, pause, shuffle, and more. I also added an example on how to use
propertiesChanged().