Bump minor version numbers for time and transformers to match version…#16
Open
mcgirr wants to merge 1 commit intoprowdsponsor:masterfrom
Open
Bump minor version numbers for time and transformers to match version…#16mcgirr wants to merge 1 commit intoprowdsponsor:masterfrom
mcgirr wants to merge 1 commit intoprowdsponsor:masterfrom
Conversation
… numbers changes in stackage lts-7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… numbers changes in stackage lts-7.0
Unless I'm incorrect, it's safe to bump the version numbers up for time and for transformers which would make yesod-auth-fb compatible with the version changes in lts-7.0
One thing to note is that in transformers the module
Control.Monad.Trans.Errorhas been deprecated andControl.Monad.Trans.Exceptis recommended instead. This only seems to affect the client side code of yesod-auth-fb and it's been deprecated since version 0.4.0.0 so it's not a new deprecation added in transformer > 0.5.