Closed
Conversation
zubri
changed the title
zubri
force-pushed
the
CU-86b3verm1_Code-cleanupimprovement
branch
from
f63c00a to
2390b49
Compare
ptorres-prowide
force-pushed
the
CU-86b3verm1_Code-cleanupimprovement
branch
2 times, most recently
from
39d2a9b to
41495f4
Compare
* ./gradlew codegenMtFields -PSRU=2025 -xtest --no-daemon * ./gradlew generateFieldEnum -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtClasses -PSRU=2025 -xtest --no-daemon * ./gradlew generateMtSequenceEnum -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtSchemes -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtProperties -PSRU=2025 -xtest --no-daemon * CU-86b4upx87_Fix-SRU-logic-for-codegen * Draft gradle.build hardcoded version
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.11.4...r5.12.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.12.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add uetr as a new property of the AbstractSwiftMessage * chore: fix version tag in javadoc * chore: changelog * chore: changelog PR number --------- Co-authored-by: zubri <sebastian@prowidesoftware.com>
ptorres-prowide
force-pushed
the
CU-86b3verm1_Code-cleanupimprovement
branch
from
d184491 to
fe8ab0a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up build scripts, updates the Gradle wrapper, and bumps the project changelog version.
- Adds SPDX license headers and standardizes error output to stderr in
gradlew.batandgradlew. - Refactors shell script logic for
APP_HOME, shellcheck directives, and Java detection; clarifies default JVM options. - Upgrades Gradle wrapper to 8.14, enables
validateDistributionUrl, and updates changelog to version 10.3.0.
Reviewed Changes
Copilot reviewed 4 out of 1032 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradlew.bat | Added SPDX header and redirected error messages to stderr |
| gradlew | Added SPDX header, improved directory resolution, updated shellcheck disables, refactored Java lookup, expanded JVM options comments |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution URL to 8.14 and enabled validateDistributionUrl |
| CHANGELOG.md | Bumped release to 10.3.0 with dependency updates and new feature entries |
Comments suppressed due to low confidence (1)
gradlew:208
- The comment duplicates 'JAVA_OPTS' and omits 'GRADLE_OPTS'. Update it to:
# * DEFAULT_JVM_OPTS, JAVA_OPTS, GRADLE_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,for clarity.
# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
Comment on lines
+48
to
+52
| echo. 1>&2 | ||
| echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2 | ||
| echo. 1>&2 | ||
| echo Please set the JAVA_HOME variable in your environment to match the 1>&2 | ||
| echo location of your Java installation. 1>&2 |
There was a problem hiding this comment.
[nitpick] The repeated echo statements with 1>&2 redirection could be grouped into a single block and redirected once to stderr (e.g., (echo. & echo ERROR: ... & echo. & echo Please ...) 1>&2) to reduce duplication.
Suggested change
| echo. 1>&2 | |
| echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2 | |
| echo. 1>&2 | |
| echo Please set the JAVA_HOME variable in your environment to match the 1>&2 | |
| echo location of your Java installation. 1>&2 | |
| ( | |
| echo. | |
| echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. | |
| echo. | |
| echo Please set the JAVA_HOME variable in your environment to match the | |
| echo location of your Java installation. | |
| ) 1>&2 |
Contributor
📝 WalkthroughWalkthroughThe updates include a new changelog entry for version 10.3.0, reflecting a SWIFT Standard update and dependency changes. The build configuration is revised for updated plugins, dependencies, and SRU versioning. The Gradle wrapper and scripts are updated for newer Gradle versions, improved licensing, error handling, and POSIX compliance. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant AbstractSwiftMessage
User->>Application: Submit SWIFT message
Application->>AbstractSwiftMessage: Instantiate with message data
AbstractSwiftMessage->>AbstractSwiftMessage: Store UETR in new field
Application->>User: Acknowledge message with UETR reference
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (2)
gradlew.bat (2)
48-52: stderr redirection nit already reported earlier
Same multi-lineecho … 1>&2pattern persists; see previous review for a concise alternative.
62-66: Duplicate of the prior stderr redirect comment
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (295)
gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarsrc/generated/java/com/prowidesoftware/swift/SchemeConstantsA.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsD.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsT.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field101.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field102.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field103.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field104.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field105.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field106.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field107.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field108.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field109.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field110.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field111.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field113.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field114.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field115.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field116.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field117.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field118.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field119.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field120.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field121.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field122.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field123.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field124.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field125.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field126.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field127.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field128.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field129.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field130.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field132.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field133.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field134.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field135.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field136.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field137.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field140.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field141.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field142.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field143.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field144.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field151.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field152.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field153.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field165.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field171.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field172.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field173.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field174.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field175.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field177.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field179.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field199.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field202.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field203.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field204.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field206.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field208.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field209.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field242.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field243.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field251.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field252.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field253.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field254.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field255.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field256.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field257.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field258.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field259.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field260.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field263.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field264.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field27.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field270.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field271.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field272.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field280.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field281.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field301.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field302.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field303.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field304.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field305.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field307.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field311.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field312.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field313.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31P.javais excluded by!**/generated/**
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)build.gradle(4 hunks)gradle/wrapper/gradle-wrapper.properties(1 hunks)gradlew(5 hunks)gradlew.bat(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (java)
- GitHub Check: Analyze (java)
🔇 Additional comments (2)
gradlew.bat (1)
16-17: SPDX header addition looks good
The explicit Apache-2.0 identifier improves license clarity.gradlew (1)
18-19: SPDX identifier addition acknowledged
Comment on lines
+3
to
+5
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true |
Contributor
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Add SHA-256 checksum for reproducible & safer builds
Nice to see the wrapper bumped to 8.14 and URL validation enabled.
For extra supply-chain protection and deterministic CI, Gradle 7.2+ supports the distributionSha256Sum property. Please publish the official checksum and pin it here so the wrapper refuses tampered downloads.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-bin.zip
+distributionSha256Sum=<official-sha256>
validateDistributionUrl=trueCommittable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In gradle/wrapper/gradle-wrapper.properties around lines 3 to 5, the file is
missing the distributionSha256Sum property for the Gradle distribution. To fix
this, obtain the official SHA-256 checksum for gradle-8.14-bin.zip from the
Gradle releases page and add a line distributionSha256Sum=<checksum> below the
distributionUrl property. This will ensure the wrapper verifies the integrity of
the downloaded distribution for safer and reproducible builds.
Comment on lines
+3
to
+9
| #### 10.3.0 - May 2025 | ||
| * SWIFT Standard release update 2025 (live 22 November 2025) | ||
| * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | ||
| * Dependency update: commons-lang3 -> 3.17.0 | ||
| * Dependency update: gson -> 2.13.1 | ||
| * Changed field 70 narrative resolver to use the free format parser, code/narrative appearing anywhere, not just at the beginning of a line | ||
| * (PW-2371) Added a `uetr` field in the `AbstractSwiftMessage` to store the message's unique end-to-end transaction reference (UETR) |
Contributor
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Fix Markdown heading & spacing for linter compliance
#### 10.3.0 jumps from H1 to H4 and bullets aren’t surrounded by blank lines.
-#### 10.3.0 - May 2025
+## 10.3.0 – May 2025
+
+* SWIFT Standard release update 2025 (live 22 Nov 2025)
+* Yearly revision of the deprecation phase
+ (see <https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/>)
+* Dependency update: commons-lang3 → 3.17.0
+* Dependency update: gson → 2.13.1
+* Changed field 70 narrative resolver to use the free-format parser (code/narrative anywhere in the line)
+* (PW-2371) Added a `uetr` field in `AbstractSwiftMessage` to store the message UETRCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3 to 9, the markdown heading level jumps from H1 to
H4 and the bullet points are not surrounded by blank lines, which violates
markdown linting rules. Adjust the heading to a consistent level, such as H2 or
H3, and add blank lines before and after the bullet list to ensure proper
spacing and linter compliance.
| } | ||
| project.version = "${SRU}-${scmVersion.version}" | ||
| //project.version = "${SRU}-9.5.0" | ||
| //project.version = "SRU2025-10.3.0" |
Contributor
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Remove stale, commented version line
The hard-coded //project.version = "SRU2025-10.3.0" can mislead future grep searches and release automation.
-//project.version = "SRU2025-10.3.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| //project.version = "SRU2025-10.3.0" |
🤖 Prompt for AI Agents
In build.gradle at line 38, remove the commented out hard-coded version line
`//project.version = "SRU2025-10.3.0"` entirely to avoid confusion and prevent
interference with grep searches and release automation.
Comment on lines
+203
to
+210
|
|
||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | ||
|
|
||
| # Collect all arguments for the java command: | ||
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | ||
| # and any embedded shellness will be escaped. | ||
| # * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be |
Contributor
There was a problem hiding this comment.
Quoted DEFAULT_JVM_OPTS breaks option parsing
xargs splits on whitespace, not on shell quoting.
With the current value each JVM arg is emitted with literal quotes, so the JVM receives:
" -Xmx64m" (including the `"`), → Unrecognised option error
Fix by removing the embedded quotes and letting xargs/sed handle word-splitting:
-DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
+DEFAULT_JVM_OPTS='-Xmx64m -Xms64m'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | |
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | |
| # Collect all arguments for the java command: | |
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | |
| # and any embedded shellness will be escaped. | |
| # * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be | |
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | |
| DEFAULT_JVM_OPTS='-Xmx64m -Xms64m' | |
| # Collect all arguments for the java command: | |
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | |
| # and any embedded shellness will be escaped. | |
| # * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be |
🤖 Prompt for AI Agents
In the gradlew file around lines 203 to 210, the DEFAULT_JVM_OPTS variable is
incorrectly quoted, causing JVM options to be passed with literal quotes and
resulting in unrecognized option errors. Remove the embedded double quotes
around each JVM option in DEFAULT_JVM_OPTS so that the options are
space-separated without quotes, allowing xargs and the shell to correctly split
and pass them to the JVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Dependency Updates
Chores