Skip to content

perf(api): add trigram indexes for finding groups#10378

Merged
AdriiiPRodri merged 2 commits intomasterfrom
feature/finding-groups-trgm-indexes
Mar 19, 2026
Merged

perf(api): add trigram indexes for finding groups#10378
AdriiiPRodri merged 2 commits intomasterfrom
feature/finding-groups-trgm-indexes

Conversation

@AdriiiPRodri
Copy link
Contributor

Context

Performance-only follow-up to #10377. This PR is optional and can be merged later to improve search speed.

Description

  • Add concurrent GIN trigram indexes for check_id and check_title on finding group summaries

Steps to review

  • Review migration 0085_finding_group_daily_summary_trgm_indexes.py
  • Apply migration during a low-traffic window

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI (if applicable)

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video - Mobile (X < 640px)
  • Screenshots/Video - Tablet (640px > X < 1024px)
  • Screenshots/Video - Desktop (X > 1024px)
  • Ensure new entries are added to ui/CHANGELOG.md

API (if applicable)

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required.
  • Ensure new entries are added to api/CHANGELOG.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Add concurrent GIN trigram indexes for check_id and check_title
@AdriiiPRodri AdriiiPRodri requested a review from a team as a code owner March 18, 2026 15:04
@github-actions github-actions bot added component/api review-django-migrations This PR contains changes in Django migrations labels Mar 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

  • api

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

🔒 Container Security Scan

Image: prowler-api:703d4fe
Last scan: 2026-03-19 09:31:06 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 5
Total 5

4 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@AdriiiPRodri AdriiiPRodri added the no-changelog Skip including change in changelog/release notes label Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (5a3475b) to head (275c86e).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10378       +/-   ##
===========================================
+ Coverage   56.85%   93.38%   +36.52%     
===========================================
  Files          87      219      +132     
  Lines        2846    30398    +27552     
===========================================
+ Hits         1618    28386    +26768     
- Misses       1228     2012      +784     
Flag Coverage Δ
api 93.38% <100.00%> (?)
prowler-py3.10-oraclecloud ?
prowler-py3.11-oraclecloud ?
prowler-py3.12-oraclecloud ?
prowler-py3.9-oraclecloud ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 93.38% <100.00%> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdriiiPRodri AdriiiPRodri merged commit ab26608 into master Mar 19, 2026
39 of 40 checks passed
@AdriiiPRodri AdriiiPRodri deleted the feature/finding-groups-trgm-indexes branch March 19, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/api no-changelog Skip including change in changelog/release notes review-django-migrations This PR contains changes in Django migrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants