fix(scans): scheduled scans duplicates #9829
Open
+336
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
10 package(s) affected
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9829 +/- ##
==========================================
+ Coverage 86.60% 92.16% +5.56%
==========================================
Files 222 180 -42
Lines 5645 24808 +19163
==========================================
+ Hits 4889 22865 +17976
- Misses 756 1943 +1187
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jfagoagas
reviewed
Jan 20, 2026
| provider_id=provider_id, | ||
| task__task_runner_task__task_id=task_id, | ||
| ).order_by("completed_at") | ||
| ).first() |
Member
There was a problem hiding this comment.
Don't you need to order it by completion time? I assume not but I can't see why.
| ): | ||
| # Duplicated task execution due to visibility timeout or scan is already running | ||
| if executed_scan: | ||
| # Duplicated task execution due to visibility timeout |
Member
There was a problem hiding this comment.
- Don't we need to increase it for this kind of tasks?
- Is the message being re-queued?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When scans are running for more than 24 hours, more than one scheduled scan can be created for the same provider, leading to unexpected behaviors and errors.
Description
With this approach, no more than one scheduled scan can be run in the same day for the same provider.
Also, when the scheduled scan task is triggered, it will take care of duplicates to clean the tenant.
Note
Locally, more than one scheduled scans were forced under the same provider. After triggering the perform scheduled scan task, the duplicated scheduled scan was deleted and the scan was properly run.
Steps to review
Please add a detailed description of how to review this PR.
Checklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.