feat: resource view re-styling with new components #9864
+2,001
−734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add paramPrefix prop to DataTableSearch, DataTablePagination, DataTable - When prefix is used, URL params become prefixed (e.g., findingsPage) - Remove client-side pagination code (clientSidePagination, clientSearchFilter) - Delete data-table-client-pagination.tsx and data-table-client-search.tsx This enables multiple paginated tables on the same page with isolated URL state (e.g., drawer table won't conflict with main page table). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace client-side pagination with getLatestFindings() server action - Use paramPrefix="findings" for isolated URL params (findingsPage, etc.) - Add findingDetailLoading state with loader when navigating to finding - Use controlled Tabs to preserve active tab when returning from finding - Filter by resource_uid and FAIL status on server side The drawer's findings table now uses proper server-side pagination with search, maintaining the same UX as main /resources and /findings tables. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Auto-formatted line breaks for better readability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
|
✅ All necessary |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
10 package(s) affected
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9864 +/- ##
==========================================
+ Coverage 86.60% 92.06% +5.46%
==========================================
Files 222 181 -41
Lines 5645 25119 +19474
==========================================
+ Hits 4889 23127 +18238
- Misses 756 1992 +1236
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
…e DOM changes when muting inside the drawer from the action button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Restyle the resources view with an improved resource detail drawer, migrating from HeroUI to shadcn/ui components.
Description
paramPrefixsupport for nested tables in drawersprovider_idfilters toResourceFilterandLatestResourceFilterin APISteps to review
/resourcesand verify the new table styling and filters work correctlyfindingsPageURL params)ui/components/ui/table/data-table.tsxforparamPrefixprop implementationapi/src/backend/api/filters.pyforprovider_idfilter additionsChecklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.