Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR improves GitHub Actions security posture by adding zizmor-based workflow scanning and tightening authentication/permissions in existing CI and release workflows.
Changes:
- Add
zizmoras a pre-commit hook to locally scan GitHub Actions workflows. - Introduce a dedicated
zizmorGitHub Actions workflow for workflow security analysis. - Harden existing workflows by disabling persisted checkout credentials and switching PyPI publishing to OIDC via
pypa/gh-action-pypi-publish.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Adds a zizmor pre-commit hook for local GitHub Actions workflow security scanning. |
| .github/workflows/zizmor.yml | New workflow to run zizmor against workflow files with restricted permissions. |
| .github/workflows/pypi-release.yml | Hardens release job permissions and switches PyPI publish to OIDC-based action. |
| .github/workflows/pull-request.yml | Disables persisted checkout credentials to reduce token exposure risk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/pypi-release.yml
Outdated
| run: | | ||
| poetry config pypi-token.pypi ${{ secrets.PYPI_API_TOKEN }} | ||
| poetry publish | ||
| uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 |
Check notice
Code scanning / zizmor
action has a known vulnerability
Avoid requesting security-events: write on pull_request trigger, which fails for fork PRs. PR runs use annotations instead of SARIF.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 64 64
Lines 1043 1043
=======================================
Hits 1012 1012
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes mismatched SHA pin and addresses critical vulnerability GHSA-vxmw-7h4f-hqxh in v1.12.4.
Description
Improve GHA security also adding
zizmorpre-commit and workflow.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.