Fix conditional attributes in exported allocator name. #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#[export_name]` already takes precedence over `#[no_mangle]`, so this is a no-op, but it silences the warning. Found with nightly. Signed-off-by: Piotr Sikora <[email protected]>
mpwarres
approved these changes
Jan 2, 2025
thibaultcha
pushed a commit
to Kong/proxy-wasm-rust-sdk
that referenced
this pull request
Jan 23, 2025
`#[export_name]` already takes precedence over `#[no_mangle]`, so this is a no-op, but it silences the warning. Found with nightly. Signed-off-by: Piotr Sikora <[email protected]>
JaatadiaMulesoft
pushed a commit
to JaatadiaMulesoft/proxy-wasm-rust-sdk
that referenced
this pull request
Jul 29, 2025
…-wasm#299)" This reverts commit c502d38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[export_name]already takes precedence over#[no_mangle],so this is a no-op, but it silences the warning.
Found with nightly.