Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Update rules_cc and add bazel_features

@mmorel-35
Copy link
Contributor Author

@PiotrSikora ,

I couldn't move them in proxy_wasm_rust_sdk_dependencies be cause otherwise I meet those errors:

ERROR: Failed to load Starlark extension '@@cc_compatibility_proxy//:symbols.bzl'.
Cycle in the workspace file detected. This indicates that a repository is used prior to being defined.
The following chain of repository dependencies lead to the missing definition.
 - @@cc_compatibility_proxy
This could either mean you have to add the '@@cc_compatibility_proxy' repository with a statement like `http_archive` in your WORKSPACE file (note that transitive dependencies are not added automatically), or move an existing definition earlier in your WORKSPACE file.
ERROR: Error computing the main repository mapping: cycles detected during computation of main repo mapping
ERROR: Failed to load Starlark extension '@@bazel_features//private:util.bzl'.
Cycle in the workspace file detected. This indicates that a repository is used prior to being defined.
The following chain of repository dependencies lead to the missing definition.
 - @@bazel_features
This could either mean you have to add the '@@bazel_features' repository with a statement like `http_archive` in your WORKSPACE file (note that transitive dependencies are not added automatically), or move an existing definition earlier in your WORKSPACE file.
ERROR: Error computing the main repository mapping: cycles detected during computation of main repo mapping

@PiotrSikora
Copy link
Member

Sigh, I think we need 4 .bzl files (similarly to what Envoy & other projects ended up with) to work around Bazel's limitations, adding those 2 files to the existing ones:

  • dependencies_bazel.bzl with bazel_features_deps(),
  • dependencies_compat.bzl with compatibility_proxy_repo().

Then it builds fine if you load: repositories, dependencies_bazel, dependencies_compat, dependencies (perhaps rename this file and function name to dependencies_crates as well, since it's going to make breakage a bit more obvious).

@PiotrSikora PiotrSikora changed the title Update rules_cc and add bazel_features Update rules_cc to v0.2.14. Nov 28, 2025
@mmorel-35 mmorel-35 force-pushed the rules_cc branch 4 times, most recently from dec65e3 to b6385dd Compare November 28, 2025 08:23
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Contributor Author

@PiotrSikora ,
If I understood you correctly, that shall fit your request

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit c4038cc into proxy-wasm:main Nov 29, 2025
23 checks passed
@mmorel-35 mmorel-35 deleted the rules_cc branch November 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants