chamber_filtration: Fix post-print filtration skipped for non-volatile filament#5187
Open
bkerler wants to merge 1 commit intoprusa3d:masterfrom
Open
chamber_filtration: Fix post-print filtration skipped for non-volatile filament#5187bkerler wants to merge 1 commit intoprusa3d:masterfrom
bkerler wants to merge 1 commit intoprusa3d:masterfrom
Conversation
bkerler
changed the title
…e filaments Needs_filtration_ is set at print start based on filament type and is false for non-volatile filaments (PLA, PETG, etc.). This caused two problems: - last_print_s_ was only updated inside the gated branch, so it was never set when printing with non-volatile filament. - The post-print condition was unreachable because execution always fell into the first (!needs_filtration_) branch and set output_pwm_ to 0. As a result, post-print filtration never activated for non-volatile filaments even when explicitly configured by the user, regardless of the backend (DIY or Advanced/official filter). Fixes prusa3d#4779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #4779.
"needs_filtration_" is set at print start based on filament type and is false for non-volatile filaments (PLA, PETG, etc.).
This caused two problems:
As a result, post-print filtration never activated for non-volatile filaments even when explicitly configured by the user, regardless of the backend (DIY or Advanced/official filter).